Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 14130021: invokeEventHandler should take a local handle (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
CC:
blink-reviews, haraken, Nate Chapin, abarth-chromium
Visibility:
Public.

Description

invokeEventHandler should take a local handle V8AbstractEventListener::invokeEventHandler currently takes a v8::Handle referring to the Event's wrapper. But using this handle in an API call is unsafe, and appears to be causing crashes (see attached bug). This patch changes it to take a v8::Local, and updates the callers to match. No tests, since there's no way to reliably force GC at the right time to trigger this crash. R=jochen@chromium.org BUG=234760 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/bindings/v8/V8AbstractEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8WorkerContextEventListener.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
7 years, 8 months ago (2013-04-23 20:58:11 UTC) #1
adamk
Note that I'm not certain this is the culprit, but it definitely looks worth fixing ...
7 years, 8 months ago (2013-04-23 21:03:50 UTC) #2
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-23 21:20:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14130021/1
7 years, 8 months ago (2013-04-23 21:28:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2560
7 years, 8 months ago (2013-04-23 22:29:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14130021/1
7 years, 8 months ago (2013-04-23 22:37:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2580
7 years, 8 months ago (2013-04-23 23:22:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14130021/1
7 years, 8 months ago (2013-04-24 05:08:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2624
7 years, 8 months ago (2013-04-24 05:33:10 UTC) #9
adamk
7 years, 8 months ago (2013-04-24 05:36:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r148971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698