Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: Source/bindings/v8/V8WorkerContextEventListener.cpp

Issue 14130021: invokeEventHandler should take a local handle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8WorkerContextEventListener.cpp
diff --git a/Source/bindings/v8/V8WorkerContextEventListener.cpp b/Source/bindings/v8/V8WorkerContextEventListener.cpp
index 5c6b00b6a26b08ee7df563f101796bd44a6513af..cfe5d11f879170ec6fae3507b26c8c74ccb2ee97 100644
--- a/Source/bindings/v8/V8WorkerContextEventListener.cpp
+++ b/Source/bindings/v8/V8WorkerContextEventListener.cpp
@@ -73,9 +73,10 @@ void V8WorkerContextEventListener::handleEvent(ScriptExecutionContext* context,
v8::Context::Scope scope(v8Context);
// Get the V8 wrapper for the event object.
- v8::Handle<v8::Value> jsEvent = toV8(event, v8::Handle<v8::Object>(), v8Context->GetIsolate());
+ v8::Isolate* isolate = v8Context->GetIsolate();
+ v8::Handle<v8::Value> jsEvent = toV8(event, v8::Handle<v8::Object>(), isolate);
- invokeEventHandler(context, event, jsEvent);
+ invokeEventHandler(context, event, v8::Local<v8::Value>::New(isolate, jsEvent));
}
v8::Local<v8::Value> V8WorkerContextEventListener::callListenerFunction(ScriptExecutionContext* context, v8::Handle<v8::Value> jsEvent, Event* event)
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698