Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: Source/bindings/v8/V8WorkerContextEventListener.cpp

Issue 14130021: invokeEventHandler should take a local handle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 return; 66 return;
67 67
68 v8::Handle<v8::Context> v8Context = script->context(); 68 v8::Handle<v8::Context> v8Context = script->context();
69 if (v8Context.IsEmpty()) 69 if (v8Context.IsEmpty())
70 return; 70 return;
71 71
72 // Enter the V8 context in which to perform the event handling. 72 // Enter the V8 context in which to perform the event handling.
73 v8::Context::Scope scope(v8Context); 73 v8::Context::Scope scope(v8Context);
74 74
75 // Get the V8 wrapper for the event object. 75 // Get the V8 wrapper for the event object.
76 v8::Handle<v8::Value> jsEvent = toV8(event, v8::Handle<v8::Object>(), v8Cont ext->GetIsolate()); 76 v8::Isolate* isolate = v8Context->GetIsolate();
77 v8::Handle<v8::Value> jsEvent = toV8(event, v8::Handle<v8::Object>(), isolat e);
77 78
78 invokeEventHandler(context, event, jsEvent); 79 invokeEventHandler(context, event, v8::Local<v8::Value>::New(isolate, jsEven t));
79 } 80 }
80 81
81 v8::Local<v8::Value> V8WorkerContextEventListener::callListenerFunction(ScriptEx ecutionContext* context, v8::Handle<v8::Value> jsEvent, Event* event) 82 v8::Local<v8::Value> V8WorkerContextEventListener::callListenerFunction(ScriptEx ecutionContext* context, v8::Handle<v8::Value> jsEvent, Event* event)
82 { 83 {
83 V8GCController::checkMemoryUsage(); 84 V8GCController::checkMemoryUsage();
84 85
85 v8::Local<v8::Function> handlerFunction = getListenerFunction(context); 86 v8::Local<v8::Function> handlerFunction = getListenerFunction(context);
86 v8::Local<v8::Object> receiver = getReceiverObject(context, event); 87 v8::Local<v8::Object> receiver = getReceiverObject(context, event);
87 if (handlerFunction.IsEmpty() || receiver.IsEmpty()) 88 if (handlerFunction.IsEmpty() || receiver.IsEmpty())
88 return v8::Local<v8::Value>(); 89 return v8::Local<v8::Value>();
(...skipping 27 matching lines...) Expand all
116 return listener; 117 return listener;
117 118
118 EventTarget* target = event->currentTarget(); 119 EventTarget* target = event->currentTarget();
119 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), toV8Con text(context, world())->GetIsolate()); 120 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), toV8Con text(context, world())->GetIsolate());
120 if (value.IsEmpty()) 121 if (value.IsEmpty())
121 return v8::Local<v8::Object>(); 122 return v8::Local<v8::Object>();
122 return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value)); 123 return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value));
123 } 124 }
124 125
125 } // namespace WebCore 126 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698