Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/DartARM32/assembler_arm.cc

Issue 1412963008: Add the PUSH instruction to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.cc
diff --git a/src/DartARM32/assembler_arm.cc b/src/DartARM32/assembler_arm.cc
index dc4bec455c20c50fd8e2499c0f328dc93b47df4a..6c174c84fee036ae4b94eff600a7fe1976e64ab2 100644
--- a/src/DartARM32/assembler_arm.cc
+++ b/src/DartARM32/assembler_arm.cc
@@ -132,7 +132,8 @@ void Assembler::EmitMemOpAddressMode3(Condition cond,
Emit(encoding);
}
-
+#if 0
+// Moved to ARM32::AssemblerARM32::emitMuliMemOp()
void Assembler::EmitMultiMemOp(Condition cond,
BlockAddressMode am,
bool load,
@@ -148,7 +149,7 @@ void Assembler::EmitMultiMemOp(Condition cond,
regs;
Emit(encoding);
}
-
+#endif
void Assembler::EmitShiftImmediate(Condition cond,
Shift opcode,
@@ -555,11 +556,15 @@ void Assembler::ldm(BlockAddressMode am, Register base, RegList regs,
}
+#if 0
+// Folded into ARM32::AssemblerARM32::pushList(), since it is its only
+// use (and doesn't implement ARM STM instruction).
void Assembler::stm(BlockAddressMode am, Register base, RegList regs,
Condition cond) {
ASSERT(regs != 0);
EmitMultiMemOp(cond, am, false, base, regs);
}
+#endif
void Assembler::ldrex(Register rt, Register rn, Condition cond) {
@@ -2561,21 +2566,23 @@ bool Address::CanHoldImmediateOffset(
}
}
-
+#if 0
+// Moved to ARM32::AssemblerARM32::push();
void Assembler::Push(Register rd, Condition cond) {
str(rd, Address(SP, -kWordSize, Address::PreIndex), cond);
}
-
+#endif
void Assembler::Pop(Register rd, Condition cond) {
ldr(rd, Address(SP, kWordSize, Address::PostIndex), cond);
}
-
+#if 0
+// Moved to ARM32::AssemblerARM32::pushList();
void Assembler::PushList(RegList regs, Condition cond) {
stm(DB_W, SP, regs, cond);
}
-
+#endif
void Assembler::PopList(RegList regs, Condition cond) {
ldm(IA_W, SP, regs, cond);
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698