Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1412963008: Add the PUSH instruction to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index 97d02d99018c2175b6c8646f229c21cafb8411b7..2a9aea7ad614d880dc0dde4fe211f01d974344a5 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -575,8 +575,12 @@ class Assembler : public ValueObject {
void ldm(BlockAddressMode am, Register base,
RegList regs, Condition cond = AL);
+#if 0
+ // Folded into ARM32::AssemblerARM32::pushList(), since it is its only
+ // use (and doesn't implement ARM STM instruction).
void stm(BlockAddressMode am, Register base,
RegList regs, Condition cond = AL);
+#endif
void ldrex(Register rd, Register rn, Condition cond = AL);
void strex(Register rd, Register rt, Register rn, Condition cond = AL);
@@ -926,10 +930,16 @@ class Assembler : public ValueObject {
void CopyFloat64x2Field(Register dst, Register src,
Register tmp1, Register tmp2, DRegister dtmp);
+#if 0
+ // Moved to ARM32::AssemblerARM32::push().
void Push(Register rd, Condition cond = AL);
+#endif
void Pop(Register rd, Condition cond = AL);
+#if 0
+ // Moved to ARM32::AssemblerARM32::pushList();
void PushList(RegList regs, Condition cond = AL);
+#endif
void PopList(RegList regs, Condition cond = AL);
void MoveRegister(Register rd, Register rm, Condition cond = AL);
@@ -1166,11 +1176,14 @@ class Assembler : public ValueObject {
Register rd,
Address ad);
+#if 0
+ // Moved to ARM32::AssemblerARM32::emitMultiMemOp()
void EmitMultiMemOp(Condition cond,
BlockAddressMode am,
bool load,
Register base,
RegList regs);
+#endif
void EmitShiftImmediate(Condition cond,
Shift opcode,
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698