device/bluetooth/bluetooth_remote_gatt_characteristic_android.h - Issue 1412963004: bluetooth: android: Implement Characteristic GetIdentifier, fix Service IDs too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.h

Issue 1412963004: bluetooth: android: Implement Characteristic GetIdentifier, fix Service IDs too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_gatt_service_unittest.cc ('k') | device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h

index 58e139d8170a50ab989931a1575bbd13047da761..7414977c543d5e400597e2e06c2b579a988f1603 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h

@@ -24,7 +24,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicAndroid

// to |bluetooth_remote_gatt_service_wrapper|.

// TODO(scheib): Actually create the Java object. crbug.com/545682

- static scoped_ptr<BluetoothRemoteGattCharacteristicAndroid> Create();

+ static scoped_ptr<BluetoothRemoteGattCharacteristicAndroid> Create(

+ const std::string& instanceId);

~BluetoothRemoteGattCharacteristicAndroid() override;

@@ -51,7 +52,10 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicAndroid

const ErrorCallback& error_callback) override;

private:

- BluetoothRemoteGattCharacteristicAndroid();

+ BluetoothRemoteGattCharacteristicAndroid(const std::string& instanceId);

+ // Adapter unique instance ID.

+ std::string instanceId_;

std::vector<uint8> value_;