chrome/browser/chromeos/extensions/users_private/users_private_api.cc - Issue 1412813003: This CL replaces user_manager::UserID with AccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names

Patch Set: Update after review. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/app_mode/kiosk_app_manager.cc ('K') | « chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc » ('j') | chrome/browser/chromeos/login/app_launch_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

index b33dff60838c5bedb54a32250b0636ce30c72bf8..7fd12867bb18a3da922d4dfef601d47ca52429fd 100644

--- a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

+++ b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

@@ -170,7 +170,8 @@ UsersPrivateRemoveWhitelistedUserFunction::Run() {

PrefsUtil* prefs_util = delegate->GetPrefsUtil();

bool removed = prefs_util->RemoveFromListCrosSetting(

chromeos::kAccountsPrefUsers, canonical_email);

- user_manager::UserManager::Get()->RemoveUser(parameters->email, NULL);

+ user_manager::UserManager::Get()->RemoveUser(

+ AccountId::FromUserEmail(parameters->email), NULL);

return RespondNow(OneArgument(new base::FundamentalValue(removed)));

}