Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Update after review. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
index bb339fe9a7b6015f39417022a44d6b82e3cad454..0dd9f22d4899af80e0f9b633d8fb0c15b5a3beb8 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
@@ -38,6 +38,7 @@
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/settings/cros_settings_names.h"
#include "components/ownership/owner_key_util.h"
+#include "components/signin/core/account_id/account_id.h"
#include "components/user_manager/user_manager.h"
#include "content/public/browser/browser_thread.h"
#include "extensions/common/extension_urls.h"
@@ -640,9 +641,9 @@ void KioskAppManager::UpdateAppData() {
const user_manager::User* active_user =
user_manager::UserManager::Get()->GetActiveUser();
if (active_user) {
- std::string active_user_id = active_user->GetUserID();
+ const AccountId active_account_id = active_user->GetAccountId();
for (const auto& it : old_apps) {
- if (it.second->user_id() == active_user_id) {
+ if (it.second->user_id() == active_account_id.GetUserEmail()) {
stevenjb 2015/10/23 17:17:02 Is GetUserEmail() just an accessor? If so, we shou
Alexander Alekseev 2015/10/23 23:21:22 user_id must return AccountId (and it will shortly
stevenjb 2015/10/26 18:28:00 So then, in case GetUserEmail doesn't get removed
VLOG(1) << "Currently running kiosk app removed from policy, exiting";
cryptohomes_barrier_closure = BarrierClosure(
old_apps.size(), base::Bind(&chrome::AttemptUserExit));

Powered by Google App Engine
This is Rietveld 408576698