Source/core/rendering/style/RenderStyle.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a few more fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 523aca6731437f192f418ab1d354f30a7a488f7d..b0764fb1e368935997bc8774d2732c6c6e522dda 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -497,7 +497,6 @@ StyleDifference RenderStyle::diff(const RenderStyle* other, unsigned& changedCon

|| rareInheritedData->textEmphasisMark != other->rareInheritedData->textEmphasisMark

|| rareInheritedData->textEmphasisPosition != other->rareInheritedData->textEmphasisPosition

|| rareInheritedData->textEmphasisCustomMark != other->rareInheritedData->textEmphasisCustomMark

- || rareInheritedData->m_textAlignLast != other->rareInheritedData->m_textAlignLast

Inactive 2014/01/17 00:54:53 What's wrong with this one?

Inactive 2014/01/17 00:56:11 Oh, it is duplicated. Nevermind.

|| rareInheritedData->m_textJustify != other->rareInheritedData->m_textJustify

|| rareInheritedData->m_textOrientation != other->rareInheritedData->m_textOrientation

|| rareInheritedData->m_tabSize != other->rareInheritedData->m_tabSize