Source/platform/exported/WebHTTPLoadInfo.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/exported/WebHTTPLoadInfo.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a few more fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/exported/WebHTTPLoadInfo.cpp

diff --git a/Source/platform/exported/WebHTTPLoadInfo.cpp b/Source/platform/exported/WebHTTPLoadInfo.cpp

index df6eeaefb17d550d4d147ffc6953a0e43c96ae4c..ce717fb9cfcd0c560ee9388f05a34830ab87f6a6 100644

--- a/Source/platform/exported/WebHTTPLoadInfo.cpp

+++ b/Source/platform/exported/WebHTTPLoadInfo.cpp

@@ -54,9 +54,8 @@ void WebHTTPLoadInfo::assign(const WebHTTPLoadInfo& r)

m_private = r.m_private;

}

-WebHTTPLoadInfo::WebHTTPLoadInfo(WTF::PassRefPtr<WebCore::ResourceLoadInfo> value)

+WebHTTPLoadInfo::WebHTTPLoadInfo(WTF::PassRefPtr<WebCore::ResourceLoadInfo> value) : m_private(value)

abarth-chromium 2014/01/17 06:59:08 The initializer should be on its own line.

{

- m_private = value;

}

WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceLoadInfo>() const