Add fuzzer-stacktrace-sk and demo

Add fuzzer-stacktrace-sk and demo

Default view (first 8 frames)
https://screenshot.googleplex.com/pxcGAoOUMPj

Expanded view (when one clicks on the horizontal expander)
https://screenshot.googleplex.com/RKmAWKSUTMi

BUG=skia:4438
Committed: https://skia.googlesource.com/buildbot/+/d172a3fe7c34ed5ee2949058f43a5b56ed486b00

[KevinL, 2015-11-05 20:42:50]

Description was changed from

==========
Add fuzzer-stacktrace-sk and demo

BUG=skia:4438
==========

to

==========
Add fuzzer-stacktrace-sk and demo

Default view (first 8 frames)
https://screenshot.googleplex.com/u9Thh1UXpnY

Expanded view (when one clicks on the horizontal expander)
https://screenshot.googleplex.com/GSo7PKtWocg

BUG=skia:4438
==========

[KevinL, 2015-11-05 20:42:50]

kjlubick@chromium.org changed reviewers:
+ jcgregorio@google.com

[KevinL, 2015-11-05 20:43:05]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[jcgregorio, 2015-11-05 21:23:37]

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
File fuzzer/res/imp/fuzzer-stacktrace-sk.html (right):

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:33: <link rel="import"
href="/res/imp/bower_components/iron-flex-layout/iron-flex-layout.html">
I don't think this is used anywhere.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:50: background-color:#DDF;
Alternating rows of #fff and #eee would be more readable while still
highlighting alternating rows.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:64: <div class="frame">
Can you make this a table so all the function names line up?

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:72: <iron-icon role="button"
id="expand" icon="icons:more-horiz" on-click="showMore" title="expand
stacktrace"></iron-icon>
Making this an icon-button will make it clearer that you can click to expand.

You can also use a paper-button with the word "More" in it.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:106: showMore: function() {
Blank line above this.

[KevinL, 2015-11-06 13:55:54]

Description was changed from

==========
Add fuzzer-stacktrace-sk and demo

Default view (first 8 frames)
https://screenshot.googleplex.com/u9Thh1UXpnY

Expanded view (when one clicks on the horizontal expander)
https://screenshot.googleplex.com/GSo7PKtWocg

BUG=skia:4438
==========

to

==========
Add fuzzer-stacktrace-sk and demo

Default view (first 8 frames)
https://screenshot.googleplex.com/pxcGAoOUMPj

Expanded view (when one clicks on the horizontal expander)
https://screenshot.googleplex.com/RKmAWKSUTMi

BUG=skia:4438
==========

[KevinL, 2015-11-06 13:56:54]

Comments addressed and screenshots updated

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
File fuzzer/res/imp/fuzzer-stacktrace-sk.html (right):

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:33: <link rel="import"
href="/res/imp/bower_components/iron-flex-layout/iron-flex-layout.html">
On 2015/11/05 21:23:37, jcgregorio wrote:
> I don't think this is used anywhere.

You are correct - removed.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:50: background-color:#DDF;
On 2015/11/05 21:23:37, jcgregorio wrote:
> Alternating rows of #fff and #eee would be more readable while still
> highlighting alternating rows.

Done.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:64: <div class="frame">
On 2015/11/05 21:23:37, jcgregorio wrote:
> Can you make this a table so all the function names line up?

Done.

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:72: <iron-icon role="button"
id="expand" icon="icons:more-horiz" on-click="showMore" title="expand
stacktrace"></iron-icon>
On 2015/11/05 21:23:37, jcgregorio wrote:
> Making this an icon-button will make it clearer that you can click to expand.
> 
> You can also use a paper-button with the word "More" in it.
> 

Changed to icon-button.  I like the icon over the word because when we put a lot
of these together: https://screenshot.googleplex.com/YXRBS2Yyihh

I'd rather not have the clutter of "More" "More" "More".

https://codereview.chromium.org/1410383012/diff/1/fuzzer/res/imp/fuzzer-stack...
fuzzer/res/imp/fuzzer-stacktrace-sk.html:106: showMore: function() {
On 2015/11/05 21:23:37, jcgregorio wrote:
> Blank line above this.

Done.

[jcgregorio, 2015-11-06 15:08:46]

lgtm

[KevinL, 2015-11-06 15:12:09]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2015-11-06 15:12:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410383012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410383012/20001

[commit-bot: I haz the power, 2015-11-06 15:14:11]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/d172a3fe7c34ed5ee2949058f43a5b56ed48...