Notification custom layouts: use DateTimeView instead of TextView.

Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of |now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617
Closed without submitting: we can never use hidden classes.

[Michael van Ouwerkerk, 2015-10-27 17:38:21]

Description was changed from

==========
Notifications custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617
==========

to

==========
Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617
==========

[Michael van Ouwerkerk, 2015-10-27 17:38:46]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2015-10-27 17:38:47]

Peter, can you do a general review please?

[Michael van Ouwerkerk, 2015-10-27 17:39:13]

mvanouwerkerk@chromium.org changed reviewers:
+ newt@chromium.org

[Michael van Ouwerkerk, 2015-10-27 17:39:14]

Newton, can you do a UI owner review please?

[Peter Beverloo, 2015-10-27 18:17:21]

lgtm

Does the framework implement this using reflection? :o

https://codereview.chromium.org/1412483006/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification.xml (right):

https://codereview.chromium.org/1412483006/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification.xml:60:
android:layout_marginStart="8dp"
dito

https://codereview.chromium.org/1412483006/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification_big.xml (right):

https://codereview.chromium.org/1412483006/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification_big.xml:83:
android:singleLine="true"
nit: place the android:singleLine after the other layout_ properties, to keep
them grouped together (like you have elsewhere)

[newt (away), 2015-10-27 21:30:00]

DateTimeView is undocumented and marked @Hide. I'm surprised this even compiles
and runs. Is there any reason to believe that it's safe to use?

[Michael van Ouwerkerk, 2015-10-28 17:09:43]

On 2015/10/27 21:30:00, newt wrote:
> DateTimeView is undocumented and marked @Hide. I'm surprised this even
compiles
> and runs. Is there any reason to believe that it's safe to use?

You're right, it seems there are no guarantees against runtime exceptions with
@hide. I'm looking for an alternative solution.

[Michael van Ouwerkerk, 2015-10-30 10:31:44]

Description was changed from

==========
Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617
==========

to

==========
Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617

Closed with submitting: we can never use hidden classes.
==========

[Michael van Ouwerkerk, 2015-10-30 10:31:44]

mvanouwerkerk@chromium.org changed reviewers:
- newt@chromium.org, peter@chromium.org

[Michael van Ouwerkerk, 2015-10-30 10:31:56]

Description was changed from

==========
Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617

Closed with submitting: we can never use hidden classes.
==========

to

==========
Notification custom layouts: use DateTimeView instead of TextView.

* Displays the time if |input time| is on the same day or within 12 hours of
|now|. Otherwise displays the date.
* Dynamically handles settings changes between 12 and 24 hour format.
* Adjustments to spacing so it looks good in Material (Holo will come later).

BUG=541617

Closed without submitting: we can never use hidden classes.
==========