Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/android/java/res/layout/web_notification_big.xml

Issue 1412483006: Notification custom layouts: use DateTimeView instead of TextView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CustomLayoutsTextStyling
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Web notification custom layout, big state. 7 Web notification custom layout, big state.
8 _______________________________________________________ 8 _______________________________________________________
9 | | | 9 | | |
10 | Icon | Title text 1:23 pm | 10 | Icon | Title text 1:23 pm |
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 style="@style/WebNotificationTitle" 67 style="@style/WebNotificationTitle"
68 android:layout_width="wrap_content" 68 android:layout_width="wrap_content"
69 android:layout_height="wrap_content" 69 android:layout_height="wrap_content"
70 android:layout_alignParentStart="true" 70 android:layout_alignParentStart="true"
71 android:layout_toStartOf="@id/time" 71 android:layout_toStartOf="@id/time"
72 android:layout_alignParentTop="true" 72 android:layout_alignParentTop="true"
73 android:layout_marginTop="4dp" 73 android:layout_marginTop="4dp"
74 android:singleLine="true" 74 android:singleLine="true"
75 android:ellipsize="end"/> 75 android:ellipsize="end"/>
76 76
77 <TextView 77 <DateTimeView
78 android:id="@+id/time" 78 android:id="@+id/time"
79 style="@style/WebNotificationTime"
80 android:layout_width="wrap_content" 79 android:layout_width="wrap_content"
81 android:layout_height="wrap_content" 80 android:layout_height="wrap_content"
82 android:layout_alignParentEnd="true" 81 android:layout_alignParentEnd="true"
83 android:layout_alignParentTop="true" 82 android:layout_alignParentTop="true"
84 android:singleLine="true"/> 83 android:singleLine="true"
Peter Beverloo 2015/10/27 18:17:21 nit: place the android:singleLine after the other
84 android:layout_marginStart="8dp"
85 android:layout_marginEnd="8dp"
86 android:layout_marginTop="8dp"
87 style="@style/WebNotificationTime"/>
85 88
86 </RelativeLayout> 89 </RelativeLayout>
87 90
88 <TextView 91 <TextView
89 android:id="@+id/body" 92 android:id="@+id/body"
90 style="@style/WebNotificationBodyBig" 93 style="@style/WebNotificationBodyBig"
91 android:layout_width="wrap_content" 94 android:layout_width="wrap_content"
92 android:layout_height="wrap_content" 95 android:layout_height="wrap_content"
93 android:layout_marginEnd="6dp" 96 android:layout_marginEnd="6dp"
94 android:layout_marginBottom="8dp" 97 android:layout_marginBottom="8dp"
(...skipping 30 matching lines...) Expand all
125 style="@style/WebNotificationOrigin" 128 style="@style/WebNotificationOrigin"
126 android:layout_width="match_parent" 129 android:layout_width="match_parent"
127 android:layout_height="wrap_content" 130 android:layout_height="wrap_content"
128 android:layout_marginBottom="10dp" 131 android:layout_marginBottom="10dp"
129 android:singleLine="true" 132 android:singleLine="true"
130 android:ellipsize="end"/> 133 android:ellipsize="end"/>
131 134
132 </LinearLayout> 135 </LinearLayout>
133 136
134 </RelativeLayout> 137 </RelativeLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698