Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1405143003: Notification custom layouts: adjust title and body text. (Closed)

Created:
5 years, 1 month ago by Michael van Ouwerkerk
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notification custom layouts: adjust title and body text. * Makes title and body look good in Material (Holo will come later) by adjusting spacing and size * Handles compact and expanded state Screenshots to compare standard vs custom in compact and expanded state: http://imgur.com/a/ZpMCq BUG=541617 Committed: https://crrev.com/18a2080eb8b6445de01fe0a8910eabcde303bb30 Cr-Commit-Position: refs/heads/master@{#356535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/android/java/res/layout/web_notification.xml View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/web_notification_big.xml View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Michael van Ouwerkerk
Peter, can you do a general review please?
5 years, 1 month ago (2015-10-27 15:12:15 UTC) #4
Michael van Ouwerkerk
Newton, can you do a review as UI owner please?
5 years, 1 month ago (2015-10-27 15:12:37 UTC) #6
Peter Beverloo
lgtm
5 years, 1 month ago (2015-10-27 16:19:06 UTC) #7
newt (away)
lgtm
5 years, 1 month ago (2015-10-27 21:23:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405143003/1
5 years, 1 month ago (2015-10-28 11:53:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 11:58:39 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 12:00:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18a2080eb8b6445de01fe0a8910eabcde303bb30
Cr-Commit-Position: refs/heads/master@{#356535}

Powered by Google App Engine
This is Rietveld 408576698