Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming

Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which
was reverted because it failed isolate tests with the error message
"telemetry_perf_unittests  lstat /b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such file or directory"

Fix to crashpad_database_util is in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util

BUG=507796
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/c3887329815bd8dc4a9c4be18c9a205520384992
Cr-Commit-Position: refs/heads/master@{#357765}

[nednguyen, 2015-10-28 21:39:25]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot.

BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/

Fix in 2nd patch.

BUG=507796
==========

[nednguyen, 2015-10-29 23:25:05]

Patchset #2 (id:20001) has been deleted

[nednguyen, 2015-10-30 00:57:35]

Patchset #2 (id:40001) has been deleted

[nednguyen, 2015-10-30 01:00:17]

Patchset #2 (id:60001) has been deleted

[nednguyen, 2015-10-30 01:02:40]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/

Fix in 2nd patch.

BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/

Fix in 2nd patch.

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[nednguyen, 2015-10-30 01:03:53]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/

Fix in 2nd patch.

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch.

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[nednguyen, 2015-10-30 01:05:11]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch.

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (chrome/chrome_tests.gypi file only, the other files' diff 
are due to rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[nednguyen, 2015-10-30 01:33:50]

nednguyen@google.com changed reviewers:
+ kbr@chromium.org, maruel@chromium.org, phajdan.jr@chromium.org

[nednguyen, 2015-10-30 02:54:36]

Patchset #2 (id:80001) has been deleted

[nednguyen, 2015-10-30 02:55:55]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (chrome/chrome_tests.gypi file only, the other files' diff 
are due to rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due swarming added)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[nednguyen, 2015-10-30 02:56:09]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due swarming added)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[nednguyen, 2015-10-30 02:56:58]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot with swarming. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

[Paweł Hajdan Jr., 2015-10-30 10:41:40]

Windows trybots seem broken on telemetry_perf_unittests . I'd prefer to review
final version of this code.

Just wondering: why didn't trybots catch the breakages that led to revert?

[nednguyen, 2015-10-30 11:11:53]

On 2015/10/30 10:41:40, Paweł Hajdan Jr. wrote:
> Windows trybots seem broken on telemetry_perf_unittests . I'd prefer to review
> final version of this code.

The telemetry_perf_unittests pass in window trybots, but the overall test fail
because the bot complains about the leaking chrome process. I thought swarming
is more lenient about the leaking processes? 

> 
> Just wondering: why didn't trybots catch the breakages that led to revert?

I am not sure about this either. My guess is the isolate tests pass in
*_chromium_rel_ng test but fail in chromium.mac.

[M-A Ruel, 2015-10-30 12:20:44]

On 2015/10/30 11:11:53, nednguyen wrote:
> On 2015/10/30 10:41:40, Paweł Hajdan Jr. wrote:
> > Windows trybots seem broken on telemetry_perf_unittests . I'd prefer to
review
> > final version of this code.
> 
> The telemetry_perf_unittests pass in window trybots, but the overall test fail
> because the bot complains about the leaking chrome process. I thought swarming
> is more lenient about the leaking processes? 

Absolutely not, that's why the last line in
https://chromium-swarm.appspot.com/user/task/2acf929dcbc0bf10 is abrasively
stating "Fix your stuff.". :)

The main difference between swarming bots and buildbot slaves is that swarming
bots enforce this strictly on Windows.

[nednguyen, 2015-10-30 12:34:25]

On 2015/10/30 12:20:44, M-A Ruel wrote:
> On 2015/10/30 11:11:53, nednguyen wrote:
> > On 2015/10/30 10:41:40, Paweł Hajdan Jr. wrote:
> > > Windows trybots seem broken on telemetry_perf_unittests . I'd prefer to
> review
> > > final version of this code.
> > 
> > The telemetry_perf_unittests pass in window trybots, but the overall test
fail
> > because the bot complains about the leaking chrome process. I thought
swarming
> > is more lenient about the leaking processes? 
> 
> Absolutely not, that's why the last line in
> https://chromium-swarm.appspot.com/user/task/2acf929dcbc0bf10 is abrasively
> stating "Fix your stuff.". :)
> 
> The main difference between swarming bots and buildbot slaves is that swarming
> bots enforce this strictly on Windows.

Given debugging the chrome process leak on window can take a while
(crbug/549562), I plan to leave chromium.win.json unchanged and only isolate +
swarm telemetry_perf_unittest on Mac + linux for now. What do you all think?

[M-A Ruel, 2015-10-30 12:36:03]

On 2015/10/30 12:34:25, nednguyen wrote:
> Given debugging the chrome process leak on window can take a while
> (crbug/549562), I plan to leave chromium.win.json unchanged and only isolate +
> swarm telemetry_perf_unittest on Mac + linux for now. What do you all think?

Ok

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
File chrome/telemetry_perf_unittests.isolate (right):

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:14: '../testing/xvfb.py',
xvfb is never needed on non linux OSes.

[nednguyen, 2015-10-30 12:37:43]

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
File chrome/telemetry_perf_unittests.isolate (right):

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:14: '../testing/xvfb.py',
On 2015/10/30 12:36:03, M-A Ruel wrote:
> xvfb is never needed on non linux OSes.

We need this to resolve the "import xvfb" on other OSes.

[M-A Ruel, 2015-10-30 12:41:18]

lgtm with CL description updated.

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
File chrome/telemetry_perf_unittests.isolate (right):

https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
chrome/telemetry_perf_unittests.isolate:14: '../testing/xvfb.py',
On 2015/10/30 12:37:43, nednguyen wrote:
> On 2015/10/30 12:36:03, M-A Ruel wrote:
> > xvfb is never needed on non linux OSes.
> 
> We need this to resolve the "import xvfb" on other OSes.

I see, I wish the import would have been conditional. Oh well.

[nednguyen, 2015-10-30 12:45:04]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and
trybot with swarming. [RELAND]

This is a reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util




BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util



BUG=507796
==========

[nednguyen, 2015-10-30 12:45:55]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other
diff in chromium.*.json are due to adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util



BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util



BUG=507796
==========

[nednguyen, 2015-10-30 14:50:00]

On 2015/10/30 12:41:18, M-A Ruel wrote:
> lgtm with CL description updated.
> 
>
https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
> File chrome/telemetry_perf_unittests.isolate (right):
> 
>
https://codereview.chromium.org/1412333004/diff/100001/chrome/telemetry_perf_...
> chrome/telemetry_perf_unittests.isolate:14: '../testing/xvfb.py',
> On 2015/10/30 12:37:43, nednguyen wrote:
> > On 2015/10/30 12:36:03, M-A Ruel wrote:
> > > xvfb is never needed on non linux OSes.
> > 
> > We need this to resolve the "import xvfb" on other OSes.
> 
> I see, I wish the import would have been conditional. Oh well.

Oh well, the test is failing on linux_chromium_rel_ng because of the credential
problem when it tries to download from cloud storage:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

 I am really baffled by the fact that the test passes without having credential
issue in the 2nd patch.

[nednguyen, 2015-10-30 14:56:23]

nednguyen@google.com changed reviewers:
+ vadim@chromium.org

[nednguyen, 2015-10-30 14:56:23]

+vadim:  linux_perf_unittest is failing on swarming bot because of the lack of
credential.

In
https://groups.google.com/a/google.com/forum/#!msg/chrome-infrastructure-team...,
you mentioned that  ~/.boto exists on all Swarming bots in Golo.

Is it failing because the swarming bots linux_perf_unittest does not have the
~/.boto file?

[nednguyen, 2015-10-30 15:18:46]

nednguyen@google.com changed reviewers:
+ vadimsh@chromium.org
- vadim@chromium.org

[nednguyen(REVIEW IN OTHER ACC), 2015-10-30 17:54:12]

The CQ bit was checked by nednguyen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 17:55:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412333004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412333004/120001

[commit-bot: I haz the power, 2015-10-30 18:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 18:26:13]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2015-11-02 11:26:57]

LGTM

[nednguyen, 2015-11-02 13:02:08]

On 2015/11/02 11:26:57, Paweł Hajdan Jr. wrote:
> LGTM

This CL is not ready to land until crbug.com/549602 is fixed.
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
shows telemetry_perf_unittests is failing.

[nednguyen, 2015-11-02 13:02:24]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util



BUG=507796
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
COMMIT=false
==========

[nednguyen, 2015-11-04 03:23:24]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
COMMIT=false
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
==========

[nednguyen, 2015-11-04 03:24:08]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 03:24:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412333004/150008
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412333004/150008

[nednguyen, 2015-11-04 04:13:06]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-11-04 04:13:11]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-11-04 04:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1412333004/#ps150008
(title: "Disable startup.warm.chrome_signin (crbug.com/551236)")

[commit-bot: I haz the power, 2015-11-04 04:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 04:13:37]

COMMIT=false detected. CQ is abandoning the patch.

[nednguyen, 2015-11-04 04:19:55]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
COMMIT=false
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

[nednguyen, 2015-11-04 04:20:03]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-11-04 04:21:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412333004/150008
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412333004/150008

[nednguyen, 2015-11-04 05:46:01]

Description was changed from

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

to

==========
Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and
trybot with swarming.

This includes the reland of https://codereview.chromium.org/1423733003/ which 
was reverted because it failed isolate tests with the error message 
"telemetry_perf_unittests  lstat
/b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such
file or directory"


Fix to crashpad_database_util is in 2nd patch. (main change in
chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to
adding swarming + rebase)

* I verify on my Mac that this build crashpad_database_util:

$ rm out/Release/crashpad_database_util
remove out/Release/crashpad_database_util? y

$ ninja  -C out/Release/ telemetry_perf_unittests
ninja: Entering directory `out/Release/'
[3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp

$ ls out/Release/crashpad_database_util
out/Release/crashpad_database_util


BUG=507796
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

[nednguyen, 2015-11-04 05:46:07]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-11-04 05:46:08]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-11-04 05:47:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412333004/150008
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412333004/150008

[commit-bot: I haz the power, 2015-11-04 05:51:39]

Committed patchset #5 (id:150008)

[commit-bot: I haz the power, 2015-11-04 05:52:29]

Patchset 5 (id:??) landed as
https://crrev.com/c3887329815bd8dc4a9c4be18c9a205520384992
Cr-Commit-Position: refs/heads/master@{#357765}

[Mostyn Bramley-Moore, 2015-11-04 08:29:41]

This seems to have broken linux gcc gyp builds (gyp error pasted below). 
breakpad/breakpad.gyp:dump_syms (the linux version) is only defined for the host
toolset, and it seems that a target toolset dep is added here.  I'm not yet sure
why this doesn't break the linux clang build.  

Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit
status 1 in /var/lib/jenkins/workspace/chromium
Updating projects from gyp files...
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 12, in <module>
    execfile(__file__ + '.py')
  File "src/build/gyp_chromium.py", line 336, in <module>
    sys.exit(main())
  File "src/build/gyp_chromium.py", line 323, in main
    gyp_rc = gyp.main(args)
  File
"/var/lib/jenkins/workspace/chromium/src/tools/gyp/pylib/gyp/__init__.py", line
538, in main
    return gyp_main(args)
  File
"/var/lib/jenkins/workspace/chromium/src/tools/gyp/pylib/gyp/__init__.py", line
514, in gyp_main
    options.duplicate_basename_check)
  File
"/var/lib/jenkins/workspace/chromium/src/tools/gyp/pylib/gyp/__init__.py", line
130, in Load
    params['parallel'], params['root_targets'])
  File "/var/lib/jenkins/workspace/chromium/src/tools/gyp/pylib/gyp/input.py",
line 2795, in Load
    RemoveLinkDependenciesFromNoneTargets(targets)
  File "/var/lib/jenkins/workspace/chromium/src/tools/gyp/pylib/gyp/input.py",
line 1510, in RemoveLinkDependenciesFromNoneTargets
    if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError:
'/var/lib/jenkins/workspace/chromium/src/breakpad/breakpad.gyp:dump_syms#target'

[Mostyn Bramley-Moore, 2015-11-04 08:49:45]

Possible fix:
https://codereview.chromium.org/1422703008

[binjin, 2015-11-04 12:07:22]

A revert of this CL (patchset #5 id:150008) has been created in
https://codereview.chromium.org/1432653002/ by binjin@chromium.org.

The reason for reverting is: Suspected to break the telemetry_perf_unittests on
Mac.