Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1427023003: [Cast,Android,PresentationAPI] Fix notification UI according to the feedback from the UI review (Closed)

Created:
5 years, 1 month ago by whywhat
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@playpause-cast-notification
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast,Android,PresentationAPI] Fix notification UI according to the feedback from the UI review See the screenshot of all the notifications types I'm trying to align here: https://drive.google.com/a/google.com/file/d/0B44CKnXso82GQUstazR0b3ZxZVZHbkRXczdVX19Udlgtbnlv/view?usp=sharing Align the one and two button case with the existing video flinging notification (see remote_notification_bar.xml). Reduce the gap between the two buttons. BUG=541629 TBR=mlamouri@chromium.org Committed: https://crrev.com/2d56a247bbf177d487accc51c23a5a4cb5622590 Cr-Commit-Position: refs/heads/master@{#357169}

Patch Set 1 #

Patch Set 2 : Revamped the change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -26 lines) Patch
M chrome/android/java/res/layout/playback_notification_bar.xml View 1 2 chunks +28 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 4 chunks +17 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
whywhat
PTaL
5 years, 1 month ago (2015-10-30 16:51:59 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 1 month ago (2015-10-30 17:39:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427023003/20001
5 years, 1 month ago (2015-10-30 18:40:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 19:23:43 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:24:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d56a247bbf177d487accc51c23a5a4cb5622590
Cr-Commit-Position: refs/heads/master@{#357169}

Powered by Google App Engine
This is Rietveld 408576698