Issue 1412103007: Version 4.8.135.3 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412103007: Version 4.8.135.3 (cherry-pick) (Closed)

Created:
5 years, 2 months ago by Michael Hablich

Modified:
5 years, 2 months ago

Reviewers:
Michael Achenbach

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@4.8.135

Target Ref:
refs/pending/heads/4.8.135

Project:
v8

Visibility:
Public.

Version 4.8.135.3 (cherry-pick) Merged a0f5d4995c9edc99b97d6b3bc3e4081891eb7f91 Merged dc9d2c16cd486b38948102df840829674f1e799a Merged 984f8af8922d368755d9dd6e2537817d66ae4530 Merged 0188aeadbbb9678eb11223a53d0bbb12d2f07ab9 Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for that. (patchset #1 id:1 of https://codereview.chromium.org/1412823003/ ) Revert of OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. (patchset #1 id:1 of https://codereview.chromium.org/1415823003/ ) Revert of Introduce LookupIterator::Restart() and use it (patchset #2 id:20001 of https://codereview.chromium.org/1416053007/ ) Revert of Reland "Use C++ implementation of Object.definePropert{y,ies}" (patchset #2 id:20001 of https://codereview.chromium.org/1413123004/ ) R=machenbach@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/d8763f7b00ac527534f5182b1028aa7f0868bf5d

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -115 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/js/v8natives.js	View	2 chunks	+44 lines, -54 lines	0 comments	Download
M	src/lookup.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/lookup.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	10 chunks	+12 lines, -36 lines	0 comments	Download
M	src/property-descriptor.cc	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	test/test262/test262.status	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Michael Hablich

5 years, 2 months ago (2015-10-23 19:29:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d8763f7b00ac527534f5182b1028aa7f0868bf5d (tree was closed).