Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: test/cctest/test-api.cc

Issue 1412103007: Version 4.8.135.3 (cherry-pick) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@4.8.135
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 8ad8a7777050e0599fbd68b6d3d419f4b20c2799..e4fcf4ad1464c48e9857b47a5273e2ba3e0f9531 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -8727,12 +8727,10 @@ TEST(AccessControlES5) {
CompileRun("other.accessible_prop = 42");
CHECK_EQ(42, g_echo_value);
- // [[DefineOwnProperty]] always throws for access-checked objects.
- CHECK(
- CompileRun("Object.defineProperty(other, 'accessible_prop', {value: 43})")
- .IsEmpty());
- CHECK(CompileRun("other.accessible_prop == 42")->IsTrue());
- CHECK_EQ(42, g_echo_value); // Make sure we didn't call the setter.
+ v8::Handle<Value> value;
+ CompileRun("Object.defineProperty(other, 'accessible_prop', {value: -1})");
+ value = CompileRun("other.accessible_prop == 42");
+ CHECK(value->IsTrue());
}
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698