Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: components/favicon/core/favicon_handler.h

Issue 1412033002: Make logic in OnFaviconDataForInitialURLFromFaviconService() the same for touch & non-touch favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_notifications
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 // Whether we got data back for the initial request to the FaviconService. 265 // Whether we got data back for the initial request to the FaviconService.
266 bool got_favicon_from_history_; 266 bool got_favicon_from_history_;
267 267
268 // Whether the history data returned in 268 // Whether the history data returned in
269 // OnFaviconDataForInitialURLFromFaviconService() is out of date or is known 269 // OnFaviconDataForInitialURLFromFaviconService() is out of date or is known
270 // to be incomplete. If true, it means there is a favicon mapped to |url_| in 270 // to be incomplete. If true, it means there is a favicon mapped to |url_| in
271 // history, but we need to redownload the icon URLs because the icon in the 271 // history, but we need to redownload the icon URLs because the icon in the
272 // database has expired or the data in the database is incomplete. 272 // database has expired or the data in the database is incomplete.
273 bool initial_history_result_expired_or_incomplete_; 273 bool initial_history_result_expired_or_incomplete_;
274 274
275 // Whether FaviconHandler should ignore history state and determine the
276 // optimal icon URL out of |image_urls_| for |url_| by downloading
277 // |image_urls_| one by one.
278 bool redownload_icons_;
279
275 // Requests to the renderer to download favicons. 280 // Requests to the renderer to download favicons.
276 typedef std::map<int, DownloadRequest> DownloadRequests; 281 typedef std::map<int, DownloadRequest> DownloadRequests;
277 DownloadRequests download_requests_; 282 DownloadRequests download_requests_;
278 283
279 // The combination of the supported icon types. 284 // The combination of the supported icon types.
280 const int icon_types_; 285 const int icon_types_;
281 286
282 // Whether the largest icon should be downloaded. 287 // Whether the largest icon should be downloaded.
283 const bool download_largest_icon_; 288 const bool download_largest_icon_;
284 289
(...skipping 21 matching lines...) Expand all
306 // available the favicon service and the current page are updated (assuming 311 // available the favicon service and the current page are updated (assuming
307 // the image is for a favicon). 312 // the image is for a favicon).
308 FaviconCandidate best_favicon_candidate_; 313 FaviconCandidate best_favicon_candidate_;
309 314
310 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 315 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
311 }; 316 };
312 317
313 } // namespace favicon 318 } // namespace favicon
314 319
315 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 320 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698