Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1411883003: Clarify that a document().frame() access in HTMLMediaElement cannot be null (Closed)

Created:
5 years, 2 months ago by philipj_slow
Modified:
5 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify that a document().frame() access in HTMLMediaElement cannot be null Access to document().frame() in HTMLMediaElement is always null-checked, so use the existing frame variable to make it obvious here as well. R=fs@opera.com Committed: https://crrev.com/f2c7f598dd277d9b79799e713da669bf29b629b9 Cr-Commit-Position: refs/heads/master@{#355771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
5 years, 2 months ago (2015-10-23 11:22:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411883003/1
5 years, 2 months ago (2015-10-23 11:22:16 UTC) #3
fs
lgtm
5 years, 2 months ago (2015-10-23 11:25:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 12:33:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411883003/1
5 years, 2 months ago (2015-10-23 13:16:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 13:19:49 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:21:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2c7f598dd277d9b79799e713da669bf29b629b9
Cr-Commit-Position: refs/heads/master@{#355771}

Powered by Google App Engine
This is Rietveld 408576698