third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 1411883003: Clarify that a document().frame() access in HTMLMediaElement cannot be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1411883003: Clarify that a document().frame() access in HTMLMediaElement cannot be null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index cbd958d391f264a0e6a8665ca3fb3af706d35116..f1334c3da09a4fd48e046b02ace7b7001c81cc40 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -1050,7 +1050,7 @@ void HTMLMediaElement::startPlayerLoad()

if (isFullscreen()) {

// This handles any transition to or from fullscreen overlay mode.

- document().frame()->chromeClient().enterFullScreenForElement(this);

+ frame->chromeClient().enterFullScreenForElement(this);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »