Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1411883003: Clarify that a document().frame() access in HTMLMediaElement cannot be null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1032 matching lines...) Expand 10 before | Expand all | Expand 10 after
1043 m_webMediaPlayer->setVolume(effectiveMediaVolume()); 1043 m_webMediaPlayer->setVolume(effectiveMediaVolume());
1044 1044
1045 m_webMediaPlayer->setPoster(posterImageURL()); 1045 m_webMediaPlayer->setPoster(posterImageURL());
1046 1046
1047 m_webMediaPlayer->setPreload(effectivePreloadType()); 1047 m_webMediaPlayer->setPreload(effectivePreloadType());
1048 1048
1049 m_webMediaPlayer->load(loadType(), kurl, corsMode()); 1049 m_webMediaPlayer->load(loadType(), kurl, corsMode());
1050 1050
1051 if (isFullscreen()) { 1051 if (isFullscreen()) {
1052 // This handles any transition to or from fullscreen overlay mode. 1052 // This handles any transition to or from fullscreen overlay mode.
1053 document().frame()->chromeClient().enterFullScreenForElement(this); 1053 frame->chromeClient().enterFullScreenForElement(this);
1054 } 1054 }
1055 } 1055 }
1056 1056
1057 void HTMLMediaElement::setPlayerPreload() 1057 void HTMLMediaElement::setPlayerPreload()
1058 { 1058 {
1059 if (m_webMediaPlayer) 1059 if (m_webMediaPlayer)
1060 m_webMediaPlayer->setPreload(effectivePreloadType()); 1060 m_webMediaPlayer->setPreload(effectivePreloadType());
1061 1061
1062 if (loadIsDeferred() && preloadType() != WebMediaPlayer::PreloadNone) 1062 if (loadIsDeferred() && preloadType() != WebMediaPlayer::PreloadNone)
1063 startDeferredLoad(); 1063 startDeferredLoad();
(...skipping 2581 matching lines...) Expand 10 before | Expand all | Expand 10 after
3645 visitor->trace(m_client); 3645 visitor->trace(m_client);
3646 } 3646 }
3647 3647
3648 DEFINE_TRACE(HTMLMediaElement::AudioSourceProviderImpl) 3648 DEFINE_TRACE(HTMLMediaElement::AudioSourceProviderImpl)
3649 { 3649 {
3650 visitor->trace(m_client); 3650 visitor->trace(m_client);
3651 } 3651 }
3652 #endif 3652 #endif
3653 3653
3654 } 3654 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698