Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411873002: emit add/sub registers instructions in integrated ARM assembler. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

emit add/sub registers instructions in integrated ARM assembler. Also cleans up comments and condition violations for all implemented ARM instructions. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4c2153b1708548f595cf82f38224c88b4fed21ed

Patch Set 1 #

Patch Set 2 : Fix nits. #

Total comments: 8

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -36 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 12 chunks +139 lines, -32 lines 0 comments Download
M tests_lit/assembler/arm32/add.ll View 1 2 3 chunks +17 lines, -3 lines 0 comments Download
M tests_lit/assembler/arm32/sub.ll View 1 2 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 2 months ago (2015-10-16 20:15:45 UTC) #2
Jim Stichnoth
otherwise lgtm https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/DartARM32/assembler_arm.h File src/DartARM32/assembler_arm.h (right): https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/DartARM32/assembler_arm.h#newcode162 src/DartARM32/assembler_arm.h:162: // Moved to encodeShiftRotatImm5() encodeShiftRotateImm5 https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/IceAssemblerARM32.cpp File ...
5 years, 2 months ago (2015-10-16 21:30:09 UTC) #3
Karl
Committed patchset #3 (id:40001) manually as 4c2153b1708548f595cf82f38224c88b4fed21ed (presubmit successful).
5 years, 2 months ago (2015-10-17 20:00:21 UTC) #4
Karl
5 years, 2 months ago (2015-10-17 20:00:42 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/DartARM32/as...
File src/DartARM32/assembler_arm.h (right):

https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/DartARM32/as...
src/DartARM32/assembler_arm.h:162: // Moved to encodeShiftRotatImm5()
On 2015/10/16 21:30:09, stichnot wrote:
> encodeShiftRotateImm5

Done.

https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1411873002/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:284: constexpr uint32_t InstType = 0; // i.e. register
On 2015/10/16 21:30:09, stichnot wrote:
> Might be clearer to name this InstTypeReg.
> (and InstTypeImm below)

Done.

https://chromiumcodereview.appspot.com/1411873002/diff/20001/tests_lit/assemb...
File tests_lit/assembler/arm32/add.ll (right):

https://chromiumcodereview.appspot.com/1411873002/diff/20001/tests_lit/assemb...
tests_lit/assembler/arm32/add.ll:4: 
On 2015/10/16 21:30:09, stichnot wrote:
> ; REQUIRES: allow_dump

Done.

https://chromiumcodereview.appspot.com/1411873002/diff/20001/tests_lit/assemb...
File tests_lit/assembler/arm32/sub.ll (right):

https://chromiumcodereview.appspot.com/1411873002/diff/20001/tests_lit/assemb...
tests_lit/assembler/arm32/sub.ll:2: 
On 2015/10/16 21:30:09, stichnot wrote:
> ; REQUIRES: allow_dump

Done.

Powered by Google App Engine
This is Rietveld 408576698