Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/DartARM32/assembler_arm.h

Issue 1411873002: emit add/sub registers instructions in integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/IceAssemblerARM32.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // This is forked from Dart revision df52deea9f25690eb8b66c5995da92b70f7ac1fe 5 // This is forked from Dart revision df52deea9f25690eb8b66c5995da92b70f7ac1fe
6 // Please update the (git) revision if we merge changes from Dart. 6 // Please update the (git) revision if we merge changes from Dart.
7 // https://code.google.com/p/dart/wiki/GettingTheSource 7 // https://code.google.com/p/dart/wiki/GettingTheSource
8 8
9 #ifndef VM_ASSEMBLER_ARM_H_ 9 #ifndef VM_ASSEMBLER_ARM_H_
10 #define VM_ASSEMBLER_ARM_H_ 10 #define VM_ASSEMBLER_ARM_H_
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 #if 0 152 #if 0
153 // Moved to decodeOperand() in IceAssemblerARM32.cpp 153 // Moved to decodeOperand() in IceAssemblerARM32.cpp
154 // Data-processing operands - Register. 154 // Data-processing operands - Register.
155 explicit Operand(Register rm) { 155 explicit Operand(Register rm) {
156 type_ = 0; 156 type_ = 0;
157 encoding_ = static_cast<uint32_t>(rm); 157 encoding_ = static_cast<uint32_t>(rm);
158 } 158 }
159 #endif 159 #endif
160 160
161 #if 0
162 // Moved to encodeShiftRotateImm5()
161 // Data-processing operands - Logical shift/rotate by immediate. 163 // Data-processing operands - Logical shift/rotate by immediate.
162 Operand(Register rm, Shift shift, uint32_t shift_imm) { 164 Operand(Register rm, Shift shift, uint32_t shift_imm) {
163 ASSERT(shift_imm < (1 << kShiftImmBits)); 165 ASSERT(shift_imm < (1 << kShiftImmBits));
164 type_ = 0; 166 type_ = 0;
165 encoding_ = shift_imm << kShiftImmShift | 167 encoding_ = shift_imm << kShiftImmShift |
166 static_cast<uint32_t>(shift) << kShiftShift | 168 static_cast<uint32_t>(shift) << kShiftShift |
167 static_cast<uint32_t>(rm); 169 static_cast<uint32_t>(rm);
168 } 170 }
171 #endif
169 172
170 // Data-processing operands - Logical shift/rotate by register. 173 // Data-processing operands - Logical shift/rotate by register.
171 Operand(Register rm, Shift shift, Register rs) { 174 Operand(Register rm, Shift shift, Register rs) {
172 type_ = 0; 175 type_ = 0;
173 encoding_ = static_cast<uint32_t>(rs) << kShiftRegisterShift | 176 encoding_ = static_cast<uint32_t>(rs) << kShiftRegisterShift |
174 static_cast<uint32_t>(shift) << kShiftShift | (1 << 4) | 177 static_cast<uint32_t>(shift) << kShiftShift | (1 << 4) |
175 static_cast<uint32_t>(rm); 178 static_cast<uint32_t>(rm);
176 } 179 }
177 180
178 static bool CanHold(uint32_t immediate, Operand* o) { 181 static bool CanHold(uint32_t immediate, Operand* o) {
(...skipping 1064 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 Register new_value, 1246 Register new_value,
1244 FieldContent old_content); 1247 FieldContent old_content);
1245 1248
1246 DISALLOW_ALLOCATION(); 1249 DISALLOW_ALLOCATION();
1247 DISALLOW_COPY_AND_ASSIGN(Assembler); 1250 DISALLOW_COPY_AND_ASSIGN(Assembler);
1248 }; 1251 };
1249 1252
1250 } // namespace dart 1253 } // namespace dart
1251 1254
1252 #endif // VM_ASSEMBLER_ARM_H_ 1255 #endif // VM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/IceAssemblerARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698