XFA: Remove null CFX_DIBAttribute default argument

XFA: Remove null CFX_DIBAttribute default argument.

Add some consts and overrides along the way.
Group some statics together.
Tidy some unused vars.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ba692bf3ab3df5d0b83fb30f9e25953bed41ed5c

[Tom Sepez, 2015-10-29 19:36:28]

Description was changed from

==========
Always provide a DIBAttribute

BUG=
==========

to

==========
Remove null CFX_DIBAttribute default argument
==========

[Tom Sepez, 2015-10-29 19:38:41]

Description was changed from

==========
Remove null CFX_DIBAttribute default argument
==========

to

==========
Remove null CFX_DIBAttribute default argument.
Add some consts and overrides along the way.
==========

[Tom Sepez, 2015-10-29 19:39:07]

Description was changed from

==========
Remove null CFX_DIBAttribute default argument.
Add some consts and overrides along the way.
==========

to

==========
XFA: Remove null CFX_DIBAttribute default argument.
Add some consts and overrides along the way.
==========

[Tom Sepez, 2015-10-29 19:41:58]

Description was changed from

==========
XFA: Remove null CFX_DIBAttribute default argument.
Add some consts and overrides along the way.
==========

to

==========
XFA: Remove null CFX_DIBAttribute default argument.

Add some consts and overrides along the way.
Group some statics together.
==========

[Tom Sepez, 2015-10-29 19:43:09]

Description was changed from

==========
XFA: Remove null CFX_DIBAttribute default argument.

Add some consts and overrides along the way.
Group some statics together.
==========

to

==========
XFA: Remove null CFX_DIBAttribute default argument.

Add some consts and overrides along the way.
Group some statics together.
Tidy some unused vars.
==========

[Tom Sepez, 2015-10-29 21:53:53]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-29 21:54:03]

Lei, for review.

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
File core/include/fxcodec/fx_codec.h (right):

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:18: #include "../fxcrt/fx_coordinates.h"  // For
FX_RECT.
note: moved because XFA only.  Will look nice when the automatic ifdefs get
added.  Henceforth, other spots where this occurs are marked with ***

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:35: class ICodec_ProgressiveDecoder;
***

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:72: ICodec_ProgressiveDecoder*
CreateProgressiveDecoder();
***

[Lei Zhang, 2015-10-30 06:06:32]

lgtm

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
File core/include/fxcodec/fx_codec.h (right):

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:18: #include "../fxcrt/fx_coordinates.h"  // For
FX_RECT.
On 2015/10/29 21:54:03, Tom Sepez wrote:
> note: moved because XFA only.  Will look nice when the automatic ifdefs get
> added.  Henceforth, other spots where this occurs are marked with ***

Acknowledged.

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:35: class ICodec_ProgressiveDecoder;
On 2015/10/29 21:54:03, Tom Sepez wrote:
> ***

Care to sort this section and the one above?

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:72: ICodec_ProgressiveDecoder*
CreateProgressiveDecoder();
On 2015/10/29 21:54:03, Tom Sepez wrote:
> ***

Acknowledged.

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:87: nonstd::unique_ptr<ICodec_PngModule>
m_pPngModule;
*** ?

https://codereview.chromium.org/1411683005/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/codec_int.h (right):

https://codereview.chromium.org/1411683005/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/codec_int.h:162: void SetPovider(IFX_JpegProvider* pJP)
override { m_pExtProvider = pJP; }
existing typo: Povider

https://codereview.chromium.org/1411683005/diff/20001/xfa/src/fxbarcode/BC_Bu...
File xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp (right):

https://codereview.chromium.org/1411683005/diff/20001/xfa/src/fxbarcode/BC_Bu...
xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp:182: CBC_LuminanceSource*
CBC_BufferedImageLuminanceSource::RotateCounterClockwise(
BTW, as is, this function has no caller.

[Tom Sepez, 2015-10-30 20:10:34]

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
File core/include/fxcodec/fx_codec.h (right):

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:35: class ICodec_ProgressiveDecoder;
On 2015/10/30 06:06:31, Lei Zhang wrote:
> On 2015/10/29 21:54:03, Tom Sepez wrote:
> > ***
> 
> Care to sort this section and the one above?

Done.  And there was a duplicate class that popped out plain as day after
sorting the first one.

https://codereview.chromium.org/1411683005/diff/20001/core/include/fxcodec/fx...
core/include/fxcodec/fx_codec.h:87: nonstd::unique_ptr<ICodec_PngModule>
m_pPngModule;
On 2015/10/30 06:06:32, Lei Zhang wrote:
> *** ?
***

https://codereview.chromium.org/1411683005/diff/20001/core/src/fxcodec/codec/...
File core/src/fxcodec/codec/codec_int.h (right):

https://codereview.chromium.org/1411683005/diff/20001/core/src/fxcodec/codec/...
core/src/fxcodec/codec/codec_int.h:162: void SetPovider(IFX_JpegProvider* pJP)
override { m_pExtProvider = pJP; }
On 2015/10/30 06:06:32, Lei Zhang wrote:
> existing typo: Povider

Another CL removes it entirely.

https://codereview.chromium.org/1411683005/diff/20001/xfa/src/fxbarcode/BC_Bu...
File xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp (right):

https://codereview.chromium.org/1411683005/diff/20001/xfa/src/fxbarcode/BC_Bu...
xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp:182: CBC_LuminanceSource*
CBC_BufferedImageLuminanceSource::RotateCounterClockwise(
On 2015/10/30 06:06:32, Lei Zhang wrote:
> BTW, as is, this function has no caller.
Removeding it gave:

obj/xfa/src/fxbarcode/xfa.BC_BufferedImageLuminanceSource.o:(.rodata._ZTV32CBC_BufferedImageLuminanceSource+0x40):
undefined reference to
`CBC_BufferedImageLuminanceSource::RotateCounterClockwise(int&)'

[Tom Sepez, 2015-10-30 20:11:35]

Committed patchset #3 (id:40001) manually as
ba692bf3ab3df5d0b83fb30f9e25953bed41ed5c (presubmit successful).