Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp

Issue 1411683005: XFA: Remove null CFX_DIBAttribute default argument (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Sort classes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fxcodec/codec/fx_codec_progress.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp
diff --git a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp
index e626c4021c7133b238c16f66c9b2689244d43fc9..01c4f6c1fdb9ea1babf84224ed992c24bcd89de5 100644
--- a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp
+++ b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp
@@ -34,7 +34,7 @@ static CFX_DIBitmap* CreateDIBSource(IFX_FileRead* fileread) {
pCodecMgr = new CCodec_ModuleMgr();
pImageCodec = pCodecMgr->CreateProgressiveDecoder();
FXCODEC_STATUS status = FXCODEC_STATUS_DECODE_FINISH;
- status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN);
+ status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN, nullptr);
if (status != FXCODEC_STATUS_FRAME_READY) {
return NULL;
}
@@ -181,11 +181,7 @@ CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::Crop(int32_t left,
}
CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::RotateCounterClockwise(
int32_t& e) {
- if (!IsRotateSupported()) {
+ if (!IsRotateSupported())
e = BCExceptionRotateNotSupported;
- return NULL;
- }
- int32_t sourceWidth = m_width;
- int32_t sourceHeight = m_height;
return NULL;
}
« no previous file with comments | « core/src/fxcodec/codec/fx_codec_progress.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698