XFA: Remove null CFX_DIBAttribute default argument

xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2009 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 16 matching lines @@
  public:
   virtual FX_BOOL NeedToPauseNow() { return TRUE; }
 };
 static CFX_DIBitmap* CreateDIBSource(IFX_FileRead* fileread) {
   CFX_DIBitmap* bitmap = NULL;
   CCodec_ModuleMgr* pCodecMgr = NULL;
   ICodec_ProgressiveDecoder* pImageCodec = NULL;
   pCodecMgr = new CCodec_ModuleMgr();
   pImageCodec = pCodecMgr->CreateProgressiveDecoder();
   FXCODEC_STATUS status = FXCODEC_STATUS_DECODE_FINISH;
-  status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN);
+  status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN, nullptr);
   if (status != FXCODEC_STATUS_FRAME_READY) {
     return NULL;
   }
   bitmap = new CFX_DIBitmap;
   bitmap->Create(pImageCodec->GetWidth(), pImageCodec->GetHeight(), FXDIB_Argb);
   bitmap->Clear(FXARGB_MAKE(0xFF, 0xFF, 0xFF, 0xFF));
   CBC_Pause pause;
   int32_t frames;
   status = pImageCodec->GetFrames(frames, &pause);
   while (status == FXCODEC_STATUS_FRAME_TOBECONTINUE) {
@@ skipping 124 matching lines @@
 }
 FX_BOOL CBC_BufferedImageLuminanceSource::IsRotateSupported() {
   return TRUE;
 }
 CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::Crop(int32_t left,
                                                             int32_t top,
                                                             int32_t width,
                                                             int32_t height) {
   return NULL;
 }
 CBC_LuminanceSource* CBC_BufferedImageLuminanceSource::RotateCounterClockwise(

[Lei Zhang, 2015/10/30 06:06:32]

BTW, as is, this function has no caller.

[Tom Sepez, 2015/10/30 20:10:34]

Removeding it gave:

obj/xfa/src/fxbarcode/xfa.BC_BufferedImageLuminanceSource.o:(.rodata._ZTV32CBC_BufferedImageLuminanceSource+0x40):
undefined reference to
`CBC_BufferedImageLuminanceSource::RotateCounterClockwise(int&)'

     int32_t& e) {
-  if (!IsRotateSupported()) {
+  if (!IsRotateSupported())
     e = BCExceptionRotateNotSupported;
-    return NULL;
-  }
-  int32_t sourceWidth = m_width;
-  int32_t sourceHeight = m_height;
   return NULL;
 }