Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework to read GYP_DEFINES/gn_args from bot configs in MB Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json
diff --git a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json b/ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json
similarity index 50%
copy from ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json
copy to ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json
index 54408813aab494e758ccd026b133cb8d3d0f71f7..c685fa74471d2348d56078a52d15bb3140e66cef 100644
--- a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json
+++ b/ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json
@@ -1,18 +1,24 @@
{
"owners": [
+ "dpranke",
"smut"
],
"comments": [
- "Builder for fat binaries using ninja."
+ "GN + Ninja simulator build."
],
"xcode version": "7.0",
"GYP_DEFINES": {
"chromium_ios_signing": "0",
"target_subarch": "both"
},
+ "gn_args": [
+ "target_os=\"ios\"",
+ "use_ios_simulator=false"
smut 2015/11/18 22:00:29 What is meant by use_ios_simulator=false? Are you
Dirk Pranke 2015/11/18 22:30:27 I don't think iossim even builds yet in GN, period
smut 2015/11/18 22:34:19 Toggles SDK? Can you use what I set on line 21? Th
Dirk Pranke 2015/11/18 22:46:20 Hmm. It looks like the way this is working is be
smut 2015/11/18 23:02:40 In that case can it be made clearer that this corr
Dirk Pranke 2015/11/19 01:05:25 Let me fix all of the typos and try again. I'm get
+ ],
+ "mb_type": "gn",
"compiler": "ninja",
- "configuration": "Release",
- "sdk": "iphoneos9.0",
+ "configuration": "Debug",
+ "sdk": "iphonesimulator9.0",
"tests": [
]
}

Powered by Google App Engine
This is Rietveld 408576698