Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework to read GYP_DEFINES/gn_args from bot configs in MB Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json
diff --git a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json b/ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json
similarity index 50%
copy from ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json
copy to ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json
index 54408813aab494e758ccd026b133cb8d3d0f71f7..b1dd4a5f3674ee0ed14545107002e0ddfb789713 100644
--- a/ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json
+++ b/ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json
@@ -1,18 +1,24 @@
{
"owners": [
+ "dpranke",
"smut"
],
"comments": [
- "Builder for fat binaries using ninja."
+ "GN + Ninja simulator build."
],
"xcode version": "7.0",
"GYP_DEFINES": {
"chromium_ios_signing": "0",
"target_subarch": "both"
},
+ "gn_args": [
+ "target_os=\"ios\"",
+ "use_ios_simulator=false"
smut 2015/11/18 22:00:29 Do you need ios_enable_code_signing=false? It's im
Dirk Pranke 2015/11/18 22:30:27 It's not needed; as you say, it's implied. I've be
Dirk Pranke 2015/11/18 22:46:20 I think this flag is wrong, just like ios_dbg_simu
+ ],
"compiler": "ninja",
- "configuration": "Release",
- "sdk": "iphoneos9.0",
+ "mb_type": "gn",
+ "configuration": "Debug",
+ "sdk": "iphonesimulator9.0",
"tests": [
]
}

Powered by Google App Engine
This is Rietveld 408576698