ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json - Issue 1411183010: Make MB aware of iOS bot configs and get iOS working.

Side by Side Diff: ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework to read GYP_DEFINES/gn_args from bot configs in MB Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json ('K') | « ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json ('k') | ios/build/bots/tryserver.chromium.mac/ios_rel_device_gn.json » ('j') | ios/build/bots/tryserver.chromium.mac/ios_rel_device_gn.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "owners": [	2 "owners": [

	3 "dpranke",

3 "smut"	4 "smut"

4 ],	5 ],

5 "comments": [	6 "comments": [

6 "Builder for fat binaries using ninja."	7 "GN + Ninja simulator build."

7 ],	8 ],

8 "xcode version": "7.0",	9 "xcode version": "7.0",

9 "GYP_DEFINES": {	10 "GYP_DEFINES": {

10 "chromium_ios_signing": "0",	11 "chromium_ios_signing": "0",

11 "target_subarch": "both"	12 "target_subarch": "both"

12 },	13 },

	14 "gn_args": [

	15 "target_os=\"ios\"",

	16 "use_ios_simulator=false"
	smut 2015/11/18 22:00:29 What is meant by use_ios_simulator=false? Are you What is meant by use_ios_simulator=false? Are you skipping compilation of iossim because you aren't running any tests below? Dirk Pranke 2015/11/18 22:30:27 I don't think iossim even builds yet in GN, period Show quoted text On 2015/11/18 22:00:29, smut wrote: > What is meant by use_ios_simulator=false? Are you skipping compilation of iossim > because you aren't running any tests below? I don't think iossim even builds yet in GN, period :). Regardless, use_ios_simulator doesn't affect it. The flag is defined in //build/config/ios/ios_sdk.gni and only used there; it controls which SDK we build (iphonesimulator or iphoneos), and also toggles a couple of defaults for code signing. smut 2015/11/18 22:34:19 Toggles SDK? Can you use what I set on line 21? Th Show quoted text On 2015/11/18 22:30:27, Dirk Pranke wrote: > On 2015/11/18 22:00:29, smut wrote: > > What is meant by use_ios_simulator=false? Are you skipping compilation of > iossim > > because you aren't running any tests below? > > I don't think iossim even builds yet in GN, period :). > > Regardless, use_ios_simulator doesn't affect it. > > The flag is defined in //build/config/ios/ios_sdk.gni and only used there; > it controls which SDK we build (iphonesimulator or iphoneos), and also > toggles a couple of defaults for code signing. Toggles SDK? Can you use what I set on line 21? That's supposed to say whether it's iphoneos or iphonesimulator. Also, if that's what it means, then shouldn't use_ios_simulator be true? This should use iphonesimulator instead of iphoneos. Dirk Pranke 2015/11/18 22:46:20 Hmm. It looks like the way this is working is be Show quoted text On 2015/11/18 22:34:19, smut wrote: > Toggles SDK? Can you use what I set on line 21? That's supposed to say whether > it's iphoneos or iphonesimulator. Hmm. It looks like the way this is working is because GYP currently generates both -iphoneos and -iphonesimulator configurations, and then you use 'sdk' to figure out which directory to build (it generates 4 directories in total when you multiple by Release/Debug) GN doesn't work that way; we only generate a single directory's worth of files. So it needs to be told which config we want via gn_args. We could modify MB to be aware of more stuff from the config file, but that would make me increasingly unhappy. WDYT? Show quoted text > > Also, if that's what it means, then shouldn't use_ios_simulator be true? This > should use iphonesimulator instead of iphoneos. Yeah, actually I think this is just a typo on my part, so, good catch :). smut 2015/11/18 23:02:40 In that case can it be made clearer that this corr Show quoted text On 2015/11/18 22:46:20, Dirk Pranke wrote: > On 2015/11/18 22:34:19, smut wrote: > > Toggles SDK? Can you use what I set on line 21? That's supposed to say whether > > it's iphoneos or iphonesimulator. > > Hmm. > > It looks like the way this is working is because GYP currently generates both > -iphoneos and -iphonesimulator configurations, and then you use 'sdk' to figure > out which directory to build (it generates 4 directories in total when you > multiple by Release/Debug) > > GN doesn't work that way; we only generate a single directory's worth of files. > So it needs to be told which config we want via gn_args. > > We could modify MB to be aware of more stuff from the config file, but > that would make me increasingly unhappy. WDYT? > > > > > Also, if that's what it means, then shouldn't use_ios_simulator be true? This > > should use iphonesimulator instead of iphoneos. > > Yeah, actually I think this is just a typo on my part, so, good catch :). In that case can it be made clearer that this corresponds with the "sdk" entry? e.g. sdk=\"iphonesimulator\" here and sdk=\"iphoneos\" in the device files. use_ios_simulator doesn't seem to really indicate that it's about SDK. Dirk Pranke 2015/11/19 01:05:25 Let me fix all of the typos and try again. I'm get Let me fix all of the typos and try again. I'm getting lost at the moment otherwise :).
	17 ],

	18 "mb_type": "gn",

13 "compiler": "ninja",	19 "compiler": "ninja",

14 "configuration": "Release",	20 "configuration": "Debug",

15 "sdk": "iphoneos9.0",	21 "sdk": "iphonesimulator9.0",

16 "tests": [	22 "tests": [

17 ]	23 ]

18 }	24 }

OLD	NEW