ios/build/bots/chromium.mac/iOS_Device_GN.json - Issue 1411183010: Make MB aware of iOS bot configs and get iOS working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/build/bots/chromium.mac/iOS_Device_GN.json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework to read GYP_DEFINES/gn_args from bot configs in MB Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/build/bots/chromium.mac/iOS_Device_GN.json

diff --git a/ios/build/bots/chromium.mac/iOS_Device_(ninja).json b/ios/build/bots/chromium.mac/iOS_Device_GN.json

similarity index 59%

copy from ios/build/bots/chromium.mac/iOS_Device_(ninja).json

copy to ios/build/bots/chromium.mac/iOS_Device_GN.json

index 54408813aab494e758ccd026b133cb8d3d0f71f7..6af2ec58c15de1d5a3e38f34e4060633e28bb04d 100644

--- a/ios/build/bots/chromium.mac/iOS_Device_(ninja).json

+++ b/ios/build/bots/chromium.mac/iOS_Device_GN.json

@@ -1,15 +1,22 @@

{

"owners": [

+ "dpranke",

"smut"

"comments": [

- "Builder for fat binaries using ninja."

+ "GN + Ninja fat binary builder."

"xcode version": "7.0",

"GYP_DEFINES": {

"chromium_ios_signing": "0",

"target_subarch": "both"

+ "gn_args": [

+ "target_os=\"ios\"",

+ "target_cpu=\"arm\"",

+ "ios_enable_code_signing=false"

smut 2015/11/18 22:00:29 Reverse the list so this is alphabetical. The esc

Dirk Pranke 2015/11/18 22:30:27 Okay. I was wondering if you'd want that or not.

+ ],

+ "mb_type": "gn",

"compiler": "ninja",

"configuration": "Release",

"sdk": "iphoneos9.0",

« no previous file with comments | « BUILD.gn ('k') | ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json » ('j') | ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json » ('J')