ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json - Issue 1411183010: Make MB aware of iOS bot configs and get iOS working.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/build/bots/chromium.mac/iOS_Simulator_GN_(dbg).json

Issue 1411183010: Make MB aware of iOS bot configs and get iOS working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework to read GYP_DEFINES/gn_args from bot configs in MB Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/build/bots/chromium.mac/iOS_Device_GN.json ('K') | « ios/build/bots/chromium.mac/iOS_Device_GN.json ('k') | ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json » ('j') | ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_gn.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "owners": [	2 "owners": [

	3 "dpranke",

3 "smut"	4 "smut"

4 ],	5 ],

5 "comments": [	6 "comments": [

6 "Builder for fat binaries using ninja."	7 "GN + Ninja simulator build."

7 ],	8 ],

8 "xcode version": "7.0",	9 "xcode version": "7.0",

9 "GYP_DEFINES": {	10 "GYP_DEFINES": {

10 "chromium_ios_signing": "0",	11 "chromium_ios_signing": "0",

11 "target_subarch": "both"	12 "target_subarch": "both"

12 },	13 },

	14 "gn_args": [

	15 "target_os=\"ios\"",

	16 "use_ios_simulator=false"
	smut 2015/11/18 22:00:29 Do you need ios_enable_code_signing=false? It's im Do you need ios_enable_code_signing=false? It's implied for simulator (even for gyp), but I've been explicit about it for gyp. Also what was the deal with target_subarch? Supporting it later? Do iOS GN builds build 32, 64, or 32+64 bit universal binaries if unspecified? Dirk Pranke 2015/11/18 22:30:27 It's not needed; as you say, it's implied. I've be Show quoted text On 2015/11/18 22:00:29, smut wrote: > Do you need ios_enable_code_signing=false? It's implied for simulator (even for > gyp), but I've been explicit about it for gyp. It's not needed; as you say, it's implied. I've been trying to prune out arguments that are not needed, because I think that makes things harder to maintain. Show quoted text > Also what was the deal with target_subarch? Supporting it later? Do iOS GN > builds build 32, 64, or 32+64 bit universal binaries if unspecified? I don't think we've really worked out how we want to handle target_subarch in a GN build yet. For starters, we don't support fat binaries at all on iOS. I think by default it'll just build 32-bit arm at the moment, but clearly we will need to fix this before too long. Dirk Pranke 2015/11/18 22:46:20 I think this flag is wrong, just like ios_dbg_simu I think this flag is wrong, just like ios_dbg_simulator_gn.
	17 ],

13 "compiler": "ninja",	18 "compiler": "ninja",

14 "configuration": "Release",	19 "mb_type": "gn",

15 "sdk": "iphoneos9.0",	20 "configuration": "Debug",

	21 "sdk": "iphonesimulator9.0",

16 "tests": [	22 "tests": [

17 ]	23 ]

18 }	24 }

OLD	NEW