dart2js: do typechecking even if suppressWarnings is on

dart2js: do typechecking even if suppressWarnings is on

this is necessary because the type of elements will not be
set unless the typechecker runs on the element. You need
the type to be set even when suppressWarnings is on because
in checked mode it is an error to declare a compiled constant
with inconsistent field types

Fixes #24653

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a4bfe1f1c7db2ad0ad71a277af5644b7e93a97d5

[Harry Terkelsen, 2015-10-20 22:38:29]

het@google.com changed reviewers:
+ sigmund@google.com

[Harry Terkelsen, 2015-10-20 22:39:17]

Description was changed from

==========
dart2js: do typechecking even if suppressWarnings is on

this is necessary because the type of elements will not be
set unless the typechecker runs on the element. You need
the type to be set even when suppressWarnings is on because
in checked mode it is an error to declare a compiled constant
with inconsistent field types

BUG=
==========

to

==========
dart2js: do typechecking even if suppressWarnings is on

this is necessary because the type of elements will not be
set unless the typechecker runs on the element. You need
the type to be set even when suppressWarnings is on because
in checked mode it is an error to declare a compiled constant
with inconsistent field types

Fixes #24653

BUG=
==========

[Siggi Cherem (dart-lang), 2015-10-21 00:03:44]

lgtm

Thanks for the quick fix !

[Harry Terkelsen, 2015-10-21 00:06:14]

Committed patchset #1 (id:1) manually as
a4bfe1f1c7db2ad0ad71a277af5644b7e93a97d5 (presubmit successful).