dart2js: do typechecking even if suppressWarnings is on

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compiler_base;
 
 import 'dart:async' show
     EventSink,
     Future;
 
@@ skipping 1971 matching lines @@
   }
 
   @override
   WorldImpact computeWorldImpact(Element element) {
     return _worldImpactCache.putIfAbsent(element, () {
       assert(compiler.parser != null);
       Node tree = compiler.parser.parse(element);
       assert(invariant(element, !element.isSynthesized || tree == null));
       ResolutionImpact resolutionImpact =
           compiler.resolver.resolve(element);
-      if (tree != null &&
-          !compiler.analyzeSignaturesOnly &&
-          !reporter.options.suppressWarnings) {
+      if (tree != null && !compiler.analyzeSignaturesOnly) {
+        // TODO(het): don't do this if suppressWarnings is on, currently we have
+        // to do it because the typechecker also sets types
         // Only analyze nodes with a corresponding [TreeElements].
         compiler.checker.check(element);
       }
       WorldImpact worldImpact =
           compiler.backend.resolutionCallbacks.transformImpact(
               resolutionImpact);
       return worldImpact;
     });
   }
 
@@ skipping 37 matching lines @@
     if (_otherDependencies == null) {
       _otherDependencies = new Setlet<Element>();
     }
     _otherDependencies.add(element.implementation);
   }
 
   Iterable<Element> get otherDependencies {
     return _otherDependencies != null ? _otherDependencies : const <Element>[];
   }
 }