Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1411153005: dart2js: do typechecking even if suppressWarnings is on (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/typechecker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 9c7995aa321fd7abeafb25a15ff95e1e88fd3e24..99c535eba592f30f6285be9f905b6b0cd4255a54 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -1989,9 +1989,9 @@ class _CompilerResolution implements Resolution {
assert(invariant(element, !element.isSynthesized || tree == null));
ResolutionImpact resolutionImpact =
compiler.resolver.resolve(element);
- if (tree != null &&
- !compiler.analyzeSignaturesOnly &&
- !reporter.options.suppressWarnings) {
+ if (tree != null && !compiler.analyzeSignaturesOnly) {
+ // TODO(het): don't do this if suppressWarnings is on, currently we have
+ // to do it because the typechecker also sets types
// Only analyze nodes with a corresponding [TreeElements].
compiler.checker.check(element);
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/typechecker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698