Error code validation for error filters.

Error code validation for error filters.

Screenshots and background can be found on the tracking bug: https://github.com/dart-lang/sdk/issues/24618

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5accd7a72edd917c2e697e0e3b3f237d96794ade

[pquitslund, 2015-10-28 22:31:40]

pquitslund@google.com changed reviewers:
+ scheglov@google.com

[pquitslund, 2015-10-28 22:37:34]

Description was changed from

==========
Error code validation for error filters.
==========

to

==========
Error code validation for error filters.

Screenshots and background can be found on the tracking bug:
https://github.com/dart-lang/sdk/issues/24618
==========

[pquitslund, 2015-10-28 22:40:53]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-10-28 23:31:06]

LGTM

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:387: const
AnalysisOptionsWarningCode('UNSUPPORTED_VALUE_ERROR',
Remove "_ERROR" or add it to the constant name. (Keeping them the same makes
debugging much easier.)

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:398: const
AnalysisOptionsWarningCode('UNRECOGNIZED_ERROR_CODE_ERROR',
Remove "_ERROR" or add it to the constant name.

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:2552: // > grep 'static const .*Code'
error.dart | awk '{print $3"."$4","}'
Unfortunately, not all of the errors are defined in that file. Search for
subclasses of ErrorCode to find them all, but I know of more in parser.dart and
scanner.dart.

[scheglov, 2015-10-28 23:32:22]

LGTM

[pquitslund, 2015-10-28 23:36:11]

Thanks!

Brian: let me know if you think we should add Scanner and Parser error codes too
and I'll throw together a follow-on CL.

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:387: const
AnalysisOptionsWarningCode('UNSUPPORTED_VALUE_ERROR',
On 2015/10/28 23:31:06, Brian Wilkerson wrote:
> Remove "_ERROR" or add it to the constant name. (Keeping them the same makes
> debugging much easier.)

Done.

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:398: const
AnalysisOptionsWarningCode('UNRECOGNIZED_ERROR_CODE_ERROR',
On 2015/10/28 23:31:06, Brian Wilkerson wrote:
> Remove "_ERROR" or add it to the constant name.

Done.

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:2552: // > grep 'static const .*Code'
error.dart | awk '{print $3"."$4","}'
On 2015/10/28 23:31:06, Brian Wilkerson wrote:
> Unfortunately, not all of the errors are defined in that file. Search for
> subclasses of ErrorCode to find them all, but I know of more in parser.dart
and
> scanner.dart.

Ha!  I knew you would point that out.  My thinking was that we could have lists
of scanner and parser errors where they live if we decided that they'd be
useful.  That said, would anyone ever be crazy enough to want to do that?!?! :)

[pquitslund, 2015-10-28 23:37:38]

Committed patchset #2 (id:20001) manually as
5accd7a72edd917c2e697e0e3b3f237d96794ade (presubmit successful).

[Brian Wilkerson, 2015-10-28 23:45:18]

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1411053003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:2552: // > grep 'static const .*Code'
error.dart | awk '{print $3"."$4","}'
> That said, would anyone ever be crazy enough to want to do that?!?! :)

Well, I have to wonder about the reasonableness of disabling (or even
down-grading) compile time errors. You're code won't execute if it has a compile
time error (assuming it get's compiled, which is a little loosely defined).

Out of curiosity, I just ran the following code on the VM:

void main() {
  print('works');
}

foo() {
  this aint valid Dart;
}

and it printed "works" and terminated normally. So I don't know what to say.
Personally I'd be tempted to omit the scanner and parser errors from this list,
but then I'd omit the compile time error codes too.

But if we intentionally don't include everything then the comment should make
explicit the fact that this is not, and is not intended to be, a complete list
(and the criteria used to decide what to include).