Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1411053003: Error code validation for error filters. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Name tweaks. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/linter/linter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 217fab75356e37d64f571c09c8858c1ed02c0d73..d212191070402a0b2413c742511e94f0b08e8279 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -501,14 +501,14 @@ class ContextManagerImpl implements ContextManager {
}
// Analysis options are processed 'in-line'.
- YamlMap analyzer = options['analyzer'];
+ YamlMap analyzer = options[AnalyzerOptions.analyzer];
if (analyzer == null) {
// No options for analyzer.
return;
}
// Set strong mode (default is false).
- bool strongMode = analyzer['strong-mode'] ?? false;
+ bool strongMode = analyzer[AnalyzerOptions.strong_mode] ?? false;
AnalysisContext context = info.context;
if (context.analysisOptions.strongMode != strongMode) {
AnalysisOptionsImpl options =
@@ -518,13 +518,13 @@ class ContextManagerImpl implements ContextManager {
}
// Set ignore patterns.
- YamlList exclude = analyzer['exclude'];
+ YamlList exclude = analyzer[AnalyzerOptions.exclude];
if (exclude != null) {
setIgnorePatternsForContext(info, exclude);
}
// Set filters.
- YamlNode filters = analyzer['errors'];
+ YamlNode filters = analyzer[AnalyzerOptions.errors];
setFiltersForContext(info, filters);
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/linter/linter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698