Error code validation for error filters.

pkg/analyzer/test/src/task/options_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.task.options_test;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
@@ skipping 107 matching lines @@
   test_perform_unsupported_analyzer_option() {
     String code = r'''
 analyzer:
   not_supported: true
 ''';
     AnalysisTarget target = newSource(optionsFilePath, code);
     computeResult(target, ANALYSIS_OPTIONS_ERRORS);
     expect(task, isGenerateOptionsErrorsTask);
     List<AnalysisError> errors = outputs[ANALYSIS_OPTIONS_ERRORS];
     expect(errors, hasLength(1));
-    expect(errors[0].errorCode, AnalysisOptionsWarningCode.UNSUPPORTED_OPTION);
-    expect(errors[0].message,
-        "The option 'not_supported' is not supported by analyzer");
+    expect(errors[0].errorCode,
+        AnalysisOptionsWarningCode.UNSUPPORTED_OPTION_WITH_LEGAL_VALUES);
+    expect(
+        errors[0].message,
+        "The option 'not_supported' is not supported by analyzer, "
+        "supported values are 'errors', 'exclude', 'plugins' and 'strong-mode'");
   }
 }
 
 @reflectiveTest
 class OptionsFileValidatorTest {
   final OptionsFileValidator validator =
       new OptionsFileValidator(new TestSource());
   final AnalysisOptionsProvider optionsProvider = new AnalysisOptionsProvider();
 
+  test_analyzer_error_code_supported() {
+    validate(
+        '''
+analyzer:
+  errors:
+    unused_local_variable: ignore
+    ''',
+        []);
+  }
+
+  test_analyzer_error_code_supported_bad_value() {
+    validate(
+        '''
+analyzer:
+  errors:
+    unused_local_variable: ftw
+    ''',
+        [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION_WITH_LEGAL_VALUES]);
+  }
+
+  test_analyzer_error_code_unsupported() {
+    validate(
+        '''
+analyzer:
+  errors:
+    not_supported: ignore
+    ''',
+        [AnalysisOptionsWarningCode.UNRECOGNIZED_ERROR_CODE]);
+  }
+
   test_analyzer_supported_exclude() {
     validate(
         '''
 analyzer:
   exclude:
     - test/_data/p4/lib/lib1.dart
     ''',
         []);
   }
-
-  test_analyzer_supported_filter() {
-    validate(
-        '''
-analyzer:
-  errors:
-    unused_local_variable: ignore
-    ''',
-        []);
-  }
 
   test_analyzer_supported_strong_mode() {
     validate(
         '''
 analyzer:
   strong-mode: true
     ''',
         []);
   }
 
   test_analyzer_unsupported_option() {
     validate(
         '''
 analyzer:
   not_supported: true
     ''',
-        [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION]);
+        [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION_WITH_LEGAL_VALUES]);
   }
 
   test_linter_supported_rules() {
     validate(
         '''
 linter:
   rules:
     - camel_case_types
     ''',
         []);
   }
 
   test_linter_unsupported_option() {
     validate(
         '''
 linter:
   unsupported: true
     ''',
-        [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION]);
+        [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION_WITH_LEGAL_VALUE]);
   }
 
   void validate(String source, List<AnalysisOptionsErrorCode> expected) {
     var options = optionsProvider.getOptionsFromString(source);
     var errors = validator.validate(options);
     expect(errors.map((AnalysisError e) => e.errorCode),
         unorderedEquals(expected));
   }
 }