Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410883006: Plumb accessing context through to access control callbacks (Closed)

Created:
5 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Plumb accessing context through to access control callbacks BUG=none LOG=n R=verwaest@chromium.org Committed: https://crrev.com/133d4a88f2fb634134a6e56c833f0d30e71c7368 Cr-Commit-Position: refs/heads/master@{#31495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -84 lines) Patch
M include/v8.h View 2 chunks +17 lines, -5 lines 0 comments Download
M src/api.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +16 lines, -10 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 29 chunks +40 lines, -43 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 10 chunks +20 lines, -16 lines 0 comments Download
M test/cctest/test-object-observe.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-10-23 07:51:02 UTC) #1
Toon Verwaest
Awesome, lgtm
5 years, 2 months ago (2015-10-23 08:08:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410883006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410883006/1
5 years, 2 months ago (2015-10-23 08:09:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 08:13:28 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 08:14:02 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/133d4a88f2fb634134a6e56c833f0d30e71c7368
Cr-Commit-Position: refs/heads/master@{#31495}

Powered by Google App Engine
This is Rietveld 408576698