Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: src/isolate.cc

Issue 1410883006: Plumb accessing context through to access control callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 64a5c05b5a38d4706469776fa9f1c22142bccc95..064568e52ff043ed142e8b4ad7c93dd59bc4de4c 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -812,27 +812,33 @@ bool Isolate::MayAccess(Handle<Context> accessing_context,
HandleScope scope(this);
Handle<Object> data;
- v8::NamedSecurityCallback callback;
+ v8::AccessCheckCallback callback = nullptr;
+ v8::NamedSecurityCallback named_callback = nullptr;
{ DisallowHeapAllocation no_gc;
AccessCheckInfo* access_check_info = GetAccessCheckInfo(this, receiver);
if (!access_check_info) return false;
- Object* fun_obj = access_check_info->named_callback();
- callback = v8::ToCData<v8::NamedSecurityCallback>(fun_obj);
- if (!callback) return false;
- data = handle(access_check_info->data(), this);
+ Object* fun_obj = access_check_info->callback();
+ callback = v8::ToCData<v8::AccessCheckCallback>(fun_obj);
+ if (!callback) {
+ fun_obj = access_check_info->named_callback();
+ named_callback = v8::ToCData<v8::NamedSecurityCallback>(fun_obj);
+ if (!named_callback) return false;
+ data = handle(access_check_info->data(), this);
+ }
}
LOG(this, ApiSecurityCheck());
{
- SaveContext save(this);
- set_context(accessing_context->native_context());
-
// Leaving JavaScript.
VMState<EXTERNAL> state(this);
+ if (callback) {
+ return callback(v8::Utils::ToLocal(accessing_context),
+ v8::Utils::ToLocal(receiver));
+ }
Handle<Object> key = factory()->undefined_value();
- return callback(v8::Utils::ToLocal(receiver), v8::Utils::ToLocal(key),
- v8::ACCESS_HAS, v8::Utils::ToLocal(data));
+ return named_callback(v8::Utils::ToLocal(receiver), v8::Utils::ToLocal(key),
+ v8::ACCESS_HAS, v8::Utils::ToLocal(data));
}
}
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698