Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: test/cctest/test-object-observe.cc

Issue 1410883006: Plumb accessing context through to access control callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api-interceptors.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-object-observe.cc
diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc
index 3f85252679314dee6056b17988c6dadff1f819b6..81edf3f40feee4dc69a5e07f0bc8ca8fb5468e3d 100644
--- a/test/cctest/test-object-observe.cc
+++ b/test/cctest/test-object-observe.cc
@@ -988,10 +988,8 @@ TEST(UseCountObjectGetNotifier) {
}
-static bool NamedAccessCheckAlwaysAllow(Local<v8::Object> global,
- Local<v8::Value> name,
- v8::AccessType type,
- Local<Value> data) {
+static bool NamedAccessCheckAlwaysAllow(Local<v8::Context> accessing_context,
+ Local<v8::Object> accessed_object) {
return true;
}
@@ -1002,7 +1000,7 @@ TEST(DisallowObserveAccessCheckedObject) {
LocalContext env;
v8::Local<v8::ObjectTemplate> object_template =
v8::ObjectTemplate::New(isolate);
- object_template->SetAccessCheckCallbacks(NamedAccessCheckAlwaysAllow, NULL);
+ object_template->SetAccessCheckCallback(NamedAccessCheckAlwaysAllow);
Local<Object> new_instance =
object_template->NewInstance(
v8::Isolate::GetCurrent()->GetCurrentContext())
@@ -1023,7 +1021,7 @@ TEST(DisallowGetNotifierAccessCheckedObject) {
LocalContext env;
v8::Local<v8::ObjectTemplate> object_template =
v8::ObjectTemplate::New(isolate);
- object_template->SetAccessCheckCallbacks(NamedAccessCheckAlwaysAllow, NULL);
+ object_template->SetAccessCheckCallback(NamedAccessCheckAlwaysAllow);
Local<Object> new_instance =
object_template->NewInstance(
v8::Isolate::GetCurrent()->GetCurrentContext())
« no previous file with comments | « test/cctest/test-api-interceptors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698