Revert "Implement FullScreen using top layer."

Revert "Implement FullScreen using top layer."

Reason for revert: Causes several issues when going into/out of fullscreen.

Implement FullScreen using top layer.

This CL is based off of https://codereview.chromium.org/788073004 by jchaffraix@.

  Replace RenderFullscreen with top layer - Take II

  This patch is strongly inspired by
  https://codereview.chromium.org/134753003/
  but is a complete rewrite of the change to:
   - understand why every bits was needed (some were not).
   - better document the differences we have with the
     specification so that we can track and fix them.

  The issue with re-attaching plugins went away due to
  https://codereview.chromium.org/23618022, which moved
  the plugin's lifecycle to the DOM.

  The tests' changes are because fullscreen doesn't center
  by default anymore but stretches the element to the
  viewport's size. Some tests were also not accounting
  for the backdrop and where thus modified.

That change didn't land due to plugin persistence issues. Those issues
should now be resolved and plugins should survive over reattach.

BUG=240576, 246077, 398599, 543946, 543954, 544175
ORIGINAL_CL=https://codereview.chromium.org/1139033006/

Review URL: https://codereview.chromium.org/1363023005

Cr-Commit-Position: refs/heads/master@{#353782}

Committed: https://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c
Cr-Commit-Position: refs/heads/master@{#355313}

[dsinclair, 2015-10-19 19:02:56]

dsinclair@chromium.org changed reviewers:
+ esprehn@chromium.org

[dsinclair, 2015-10-19 19:02:56]

PTAL.

[esprehn, 2015-10-19 19:46:09]

On 2015/10/19 at 19:02:56, dsinclair wrote:
> PTAL.

Where's the bug that tracks the reason for the revert? What were the issues?

[dsinclair, 2015-10-19 19:46:59]

On 2015/10/19 19:46:09, esprehn wrote:
> On 2015/10/19 at 19:02:56, dsinclair wrote:
> > PTAL.
> 
> Where's the bug that tracks the reason for the revert? What were the issues?


I updated the BUG= line with the three filed failures: 543946, 543954, 544175

[esprehn, 2015-10-19 20:51:45]

lgtm

[dsinclair, 2015-10-19 20:52:45]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2015-10-19 20:53:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410833004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410833004/1

[commit-bot: I haz the power, 2015-10-19 22:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 22:16:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dsinclair, 2015-10-20 13:23:31]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2015-10-20 13:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410833004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410833004/1

[commit-bot: I haz the power, 2015-10-20 14:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 14:51:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dsinclair, 2015-10-20 18:36:30]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2015-10-20 18:38:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410833004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410833004/1

[commit-bot: I haz the power, 2015-10-20 19:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 19:58:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dsinclair, 2015-10-20 20:01:07]

dsinclair@chromium.org changed reviewers:
+ philipj@opera.com

[dsinclair, 2015-10-20 20:01:08]

I'm not sure why this test would be timing out when I'm reverting. As far as I
can tell the test was added before I landed this CL to begin with?

philipj@ do you know why the failing test is timing out now?

[philipj_slow, 2015-10-21 10:36:13]

On 2015/10/20 20:01:08, dsinclair wrote:
> I'm not sure why this test would be timing out when I'm reverting. As far as I
> can tell the test was added before I landed this CL to begin with?
> 
> philipj@ do you know why the failing test is timing out now?

No, I don't know, this test is intended to ensure that one can't request
fullscreen in an iframe while its sibling iframe is in fullscreen, but that has
very little to do with the layout. If it is a real regression, I would have to
suspect that it goes wrong inside the trusted_request helper, since the layout
has changed it's at least possible that the click event ends up in another
document than intended.

Something must have happened since you landed the CL, but I have no idea what.

[dsinclair, 2015-10-21 13:56:45]

On 2015/10/21 10:36:13, philipj wrote:
> On 2015/10/20 20:01:08, dsinclair wrote:
> > I'm not sure why this test would be timing out when I'm reverting. As far as
I
> > can tell the test was added before I landed this CL to begin with?
> > 
> > philipj@ do you know why the failing test is timing out now?
> 
> No, I don't know, this test is intended to ensure that one can't request
> fullscreen in an iframe while its sibling iframe is in fullscreen, but that
has
> very little to do with the layout. If it is a real regression, I would have to
> suspect that it goes wrong inside the trusted_request helper, since the layout
> has changed it's at least possible that the click event ends up in another
> document than intended.
> 
> Something must have happened since you landed the CL, but I have no idea what.

Interesting, it times out in Release builds but not Debug builds. Seems like a
timing issue.

[dsinclair, 2015-10-21 16:39:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2015-10-21 16:39:03]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1410833004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-10-21 16:39:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410833004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410833004/40001

[commit-bot: I haz the power, 2015-10-21 16:51:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-21 16:52:59]

Patchset 3 (id:??) landed as
https://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c
Cr-Commit-Position: refs/heads/master@{#355313}