Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1410833004: Revert "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 1941a4d1802aab2c77ecfc4ea35b76f299bfce22..8c97a4c44930dab5518a0139b8bedaaf65f6f351 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -28,7 +28,6 @@
#include "config.h"
#include "core/dom/Fullscreen.h"
-#include "bindings/core/v8/ExceptionMessages.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
#include "core/dom/ElementTraversal.h"
@@ -42,9 +41,8 @@
#include "core/html/HTMLMediaElement.h"
#include "core/input/EventHandler.h"
#include "core/inspector/ConsoleMessage.h"
+#include "core/layout/LayoutFullScreen.h"
#include "core/page/ChromeClient.h"
-#include "core/page/Page.h"
-#include "core/style/ComputedStyle.h"
#include "platform/UserGestureIndicator.h"
namespace blink {
@@ -161,6 +159,7 @@ bool Fullscreen::isFullScreen(Document& document)
Fullscreen::Fullscreen(Document& document)
: DocumentLifecycleObserver(&document)
+ , m_fullScreenLayoutObject(nullptr)
, m_eventQueueTimer(this, &Fullscreen::eventQueueTimerFired)
{
document.setHasFullscreenSupplement();
@@ -179,6 +178,9 @@ void Fullscreen::documentWasDetached()
{
m_eventQueue.clear();
+ if (m_fullScreenLayoutObject)
+ m_fullScreenLayoutObject->destroy();
+
#if ENABLE(OILPAN)
m_fullScreenElement = nullptr;
m_fullScreenElementStack.clear();
@@ -423,12 +425,28 @@ bool Fullscreen::fullscreenEnabled(Document& document)
void Fullscreen::didEnterFullScreenForElement(Element* element)
{
ASSERT(element);
- ASSERT(element->isInTopLayer());
-
if (!document()->isActive())
return;
+ if (m_fullScreenLayoutObject)
+ m_fullScreenLayoutObject->unwrapLayoutObject();
+
m_fullScreenElement = element;
+
+ // Create a placeholder block for a the full-screen element, to keep the page from reflowing
+ // when the element is removed from the normal flow. Only do this for a LayoutBox, as only
+ // a box will have a frameRect. The placeholder will be created in setFullScreenLayoutObject()
+ // during layout.
+ LayoutObject* layoutObject = m_fullScreenElement->layoutObject();
+ bool shouldCreatePlaceholder = layoutObject && layoutObject->isBox();
+ if (shouldCreatePlaceholder) {
+ m_savedPlaceholderFrameRect = toLayoutBox(layoutObject)->frameRect();
+ m_savedPlaceholderComputedStyle = ComputedStyle::clone(layoutObject->styleRef());
+ }
+
+ if (m_fullScreenElement != document()->documentElement())
+ LayoutFullScreen::wrapLayoutObject(layoutObject, layoutObject ? layoutObject->parent() : 0, document());
+
m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);
// FIXME: This should not call updateStyleIfNeeded.
@@ -451,11 +469,13 @@ void Fullscreen::didExitFullScreenForElement(Element*)
if (!document()->isActive())
return;
- document()->removeFromTopLayer(m_fullScreenElement.get());
m_fullScreenElement->willStopBeingFullscreenElement();
m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false);
+ if (m_fullScreenLayoutObject)
+ m_fullScreenLayoutObject->unwrapLayoutObject();
+
m_fullScreenElement = nullptr;
document()->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::FullScreen));
@@ -472,12 +492,28 @@ void Fullscreen::didExitFullScreenForElement(Element*)
from(*exitingDocument).m_eventQueueTimer.startOneShot(0, BLINK_FROM_HERE);
}
-void Fullscreen::didUpdateSize(Element& element)
+void Fullscreen::setFullScreenLayoutObject(LayoutFullScreen* layoutObject)
+{
+ if (layoutObject == m_fullScreenLayoutObject)
+ return;
+
+ if (layoutObject && m_savedPlaceholderComputedStyle) {
+ layoutObject->createPlaceholder(m_savedPlaceholderComputedStyle.release(), m_savedPlaceholderFrameRect);
+ } else if (layoutObject && m_fullScreenLayoutObject && m_fullScreenLayoutObject->placeholder()) {
+ LayoutBlock* placeholder = m_fullScreenLayoutObject->placeholder();
+ layoutObject->createPlaceholder(ComputedStyle::clone(placeholder->styleRef()), placeholder->frameRect());
+ }
+
+ if (m_fullScreenLayoutObject)
+ m_fullScreenLayoutObject->unwrapLayoutObject();
+ ASSERT(!m_fullScreenLayoutObject);
+
+ m_fullScreenLayoutObject = layoutObject;
+}
+
+void Fullscreen::fullScreenLayoutObjectDestroyed()
{
- // StyleAdjuster will set the size so we need to do a style recalc.
- // Normally changing size means layout so just doing a style recalc is a
- // bit surprising.
- element.setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::FullScreen));
+ m_fullScreenLayoutObject = nullptr;
}
void Fullscreen::enqueueChangeEvent(Document& document, RequestType requestType)
@@ -566,14 +602,12 @@ void Fullscreen::popFullscreenElementStack()
if (m_fullScreenElementStack.isEmpty())
return;
- document()->removeFromTopLayer(m_fullScreenElementStack.last().first.get());
m_fullScreenElementStack.removeLast();
}
void Fullscreen::pushFullscreenElementStack(Element& element, RequestType requestType)
{
m_fullScreenElementStack.append(std::make_pair(&element, requestType));
- document()->addToTopLayer(&element);
}
DEFINE_TRACE(Fullscreen)
« no previous file with comments | « third_party/WebKit/Source/core/dom/Fullscreen.h ('k') | third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698