Use common display initialization logic for Unix

Use common display initialization logic for Unix

BUG=skia:

[joshualitt, 2015-10-15 20:03:29]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-10-15 20:03:29]

This is a baby step towards centralized GLContextCreation

[bsalomon, 2015-10-15 20:55:27]

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
File src/gpu/gl/glx/GrNativeDisplay_glx.h (right):

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.h:14: namespace GrNativeDisplay {
Wondering why a namespace and generic function name. Is the idea to different
implementations of GrNativeDislay::Initialize with different params for
different display systems? 

Wondering if it should just be GrGLX.h with a function GrInitializeGLX()?

[robertphillips, 2015-10-16 14:54:41]

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
File src/gpu/gl/glx/GrNativeDisplay_glx.cpp (right):

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.cpp:14: 
const int* visualAttribs ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.cpp:16: SkASSERT(visualAttribs && display &&
bestConfig);
glxMajor, glxMinor ?

Do we even need the glx ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.cpp:37: //SkDebugf("Getting
XVisualInfos.\n");
bestFBC, maxNumSamples ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.cpp:43: if (vi) {
sampleBuffers ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.cpp:51: 
add {} to this ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
File src/gpu/gl/glx/GrNativeDisplay_glx.h (right):

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.h:8: 
GrNativeDisplay_glx_DEFINED ?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/GrNative...
src/gpu/gl/glx/GrNativeDisplay_glx.h:15: 
// Iterate through all the configs compatible with 'visualAttribs' and return
// the best in 'bestConfig'. In this case best means supporting the most
// MSAA samples.

?

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/SkCreate...
File src/gpu/gl/glx/SkCreatePlatformGLContext_glx.cpp (right):

https://codereview.chromium.org/1410593002/diff/20001/src/gpu/gl/glx/SkCreate...
src/gpu/gl/glx/SkCreatePlatformGLContext_glx.cpp:80: // Get a matching FB config
visualAttribs ?
static const ?

https://codereview.chromium.org/1410593002/diff/20001/src/views/unix/SkOSWind...
File src/views/unix/SkOSWindow_Unix.cpp (right):

https://codereview.chromium.org/1410593002/diff/20001/src/views/unix/SkOSWind...
src/views/unix/SkOSWindow_Unix.cpp:87: 
static const int attrs[] ?

https://codereview.chromium.org/1410593002/diff/20001/src/views/unix/SkOSWind...
src/views/unix/SkOSWindow_Unix.cpp:90: GLX_DOUBLEBUFFER, true,
Don't we need these stencil settings in the other location too ?

https://codereview.chromium.org/1410593002/diff/20001/src/views/unix/SkOSWind...
src/views/unix/SkOSWindow_Unix.cpp:115: if (info) {
Shouldn't this be requestedMSAASampleCount ?