src/gpu/gl/glx/GrNativeDisplay_glx.h - Issue 1410593002: Use common display initialization logic for Unix

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/gpu/gl/glx/GrNativeDisplay_glx.h

Issue 1410593002: Use common display initialization logic for Unix (Closed) Base URL: https://skia.googlesource.com/skia.git@vbnvpr

Patch Set: minor tidy Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2015 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 *

	7 */

	8
	robertphillips 2015/10/16 14:54:40 GrNativeDisplay_glx_DEFINED ? GrNativeDisplay_glx_DEFINED ?
	9 #ifndef GrNativeDrawable_glx_DEFINED

	10 #define GrNativeDrawable_glx_DEFINED

	11

	12 #include <GL/glx.h>

	13

	14 namespace GrNativeDisplay {
	bsalomon 2015/10/15 20:55:27 Wondering why a namespace and generic function nam Wondering why a namespace and generic function name. Is the idea to different implementations of GrNativeDislay::Initialize with different params for different display systems? Wondering if it should just be GrGLX.h with a function GrInitializeGLX()?
	15
	robertphillips 2015/10/16 14:54:40 // Iterate through all the configs compatible with // Iterate through all the configs compatible with 'visualAttribs' and return // the best in 'bestConfig'. In this case best means supporting the most // MSAA samples. ?
	16 bool Initialize(int* visualAttribs, Display, GLXFBConfig outBestConfig);

	17

	18 };

	19

	20 #endif

OLD	NEW