Add NVPR to VisualBench

Add NVPR to VisualBench

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c9dd93cd5bf72a236a14693b04f5e5c983e32ba4

[joshualitt, 2015-10-15 14:57:36]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-10-15 14:57:37]

The config handling stuff is really ad-hoc now, I'll try to fix this stuff in a
follow on.

[robertphillips, 2015-10-15 16:17:50]

lgtm + questions

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Visua...
File tools/VisualBench/VisualBenchmarkStream.cpp (right):

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualBenchmarkStream.cpp:122: 
shouldn't there be an else here ?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
File tools/VisualBench/WrappedBenchmark.h (right):

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:7: 
Change this name ?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:13: 
// Wrap some other benchmark to allow specialization to either
// cpu or gpu backends. The derived class will override 'setupOffscreen'
// to create an offscreen surface in which the actual rendering will occur.

?

What does this mean for NVPR perf since we won't be rendering to the screen?
What does it mean for raster?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:49: private:
setupOffScreen ?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:55: 
// Create a raster surface for off screen rendering

?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:67: 
// Create an MSAA & NVPR-enabled GPU backend

?

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:85: 
fix trailing comment ?

[joshualitt, 2015-10-15 16:39:47]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-10-15 16:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1409603004/#ps60001
(title: "tweaks")

[commit-bot: I haz the power, 2015-10-15 16:39:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409603004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409603004/60001

[joshualitt, 2015-10-15 16:40:05]

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Visua...
File tools/VisualBench/VisualBenchmarkStream.cpp (right):

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualBenchmarkStream.cpp:122: 
On 2015/10/15 16:17:50, robertphillips wrote:
> shouldn't there be an else here ?

Acknowledged.

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
File tools/VisualBench/WrappedBenchmark.h (right):

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:7: 
On 2015/10/15 16:17:50, robertphillips wrote:
> Change this name ?

Acknowledged.

https://codereview.chromium.org/1409603004/diff/40001/tools/VisualBench/Wrapp...
tools/VisualBench/WrappedBenchmark.h:13: 
On 2015/10/15 16:17:50, robertphillips wrote:
> // Wrap some other benchmark to allow specialization to either
> // cpu or gpu backends. The derived class will override 'setupOffscreen'
> // to create an offscreen surface in which the actual rendering will occur.
> 
> ?
> 
> What does this mean for NVPR perf since we won't be rendering to the screen?
> What does it mean for raster?

Both of these are true costs, because neither can render to the screen. 
However, we may end up adding hybrid modes, ie GPU to offscreen, NVPR -
mixedsamples to fb 0

[commit-bot: I haz the power, 2015-10-15 16:49:34]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c9dd93cd5bf72a236a14693b04f5e5c983e32ba4

[commit-bot: I haz the power, 2015-10-15 17:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:01:03]

No file was found in this patchset.