Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Issue 1410533005: [Contextual Search] Re-enabling tests. (Closed)

Created:
5 years, 1 month ago by pedro (no code reviews)
Modified:
5 years, 1 month ago
Reviewers:
Donn Denman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Re-enabling tests. I fixed the annotation to prevent some tests from running on tablets, which fixes failures we were seeing yesterday: https://codereview.chromium.org/1413003007 Not sure exactly what happen, if my change didn't get rolled in time or what, but someone else ended up disabling those tests: https://codereview.chromium.org/1406963007 So, now I'm re-enabling those tests. I'm also making sure to annotate all tests that call tapPeekingBarToExpandAndAssert() with RESTRICTION_TYPE_PHONE, because that assertion will always fail on tablets, given there's no expanded state in that case. BUG=551711 Committed: https://crrev.com/4bde7aed3c12374a873705efbf0c974a0d68f197 Cr-Commit-Position: refs/heads/master@{#358118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 9 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pedro (no code reviews)
Donn, as we discussed, please take a look at this change.
5 years, 1 month ago (2015-11-05 19:41:27 UTC) #3
Donn Denman
LGTM: Looks like a couple of tests just we not restricted to Phone, but now ...
5 years, 1 month ago (2015-11-05 19:45:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410533005/1
5 years, 1 month ago (2015-11-05 19:46:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 20:20:44 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4bde7aed3c12374a873705efbf0c974a0d68f197 Cr-Commit-Position: refs/heads/master@{#358118}
5 years, 1 month ago (2015-11-05 20:21:41 UTC) #8
pedro (no code reviews)
5 years, 1 month ago (2015-11-05 22:35:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1415683012/ by pedrosimonetti@chromium.org.

The reason for reverting is: Failing test:

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/23204.

Powered by Google App Engine
This is Rietveld 408576698