Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1413003007: [Contextual Search] Fix test annotations. (Closed)

Created:
5 years, 1 month ago by pedro (no code reviews)
Modified:
5 years, 1 month ago
Reviewers:
Donn Denman
CC:
chromium-reviews, aurimas (slooooooooow), mdjones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fix test annotations. Tests that expand Panel to expand after tapping on the bar should not run on Tablets, since there's no expanded state in the Tablet UI. This CL also fixes some minor inconsistences in some comments. BUG=551711 Committed: https://crrev.com/8a9cdb0a1a8f12e0d56ea942c4eed76d31bb79eb Cr-Commit-Position: refs/heads/master@{#357981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 12 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Donn Denman
lgtm
5 years, 1 month ago (2015-11-05 01:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413003007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413003007/1
5 years, 1 month ago (2015-11-05 01:50:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 02:19:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 02:20:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a9cdb0a1a8f12e0d56ea942c4eed76d31bb79eb
Cr-Commit-Position: refs/heads/master@{#357981}

Powered by Google App Engine
This is Rietveld 408576698