Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3155)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Issue 1410533005: [Contextual Search] Re-enabling tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
index 4bf90288c1fd91f7d92369628855c61acea96cf9..94bf30e843cf85ae485b132d763372438163d8c0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
@@ -1060,7 +1060,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
* @SmallTest
* @Feature({"ContextualSearch"})
*/
- @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+ @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@FlakyTest
public void testTapExpand() throws InterruptedException, TimeoutException {
assertNoSearchesLoaded();
@@ -1861,7 +1861,7 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
* @SmallTest
* @Feature({"ContextualSearch"})
*/
- @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+ @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@CommandLineFlags.Add({
ContextualSearchFieldTrial.PROMO_ON_LIMITED_TAPS + "=true",
ContextualSearchFieldTrial.TAP_TRIGGERED_PROMO_LIMIT + "=2"})
@@ -2256,7 +2256,6 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests that tap followed by expand makes Content visible.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
@Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@@ -2278,7 +2277,6 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
* Tests that long press followed by expand creates Content and makes it visible.
*
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
@Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@@ -2301,10 +2299,9 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests swiping panel up and down after a tap search will only load the Content once.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
- @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+ @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
public void testTapMultipleSwipeOnlyLoadsContentOnce()
throws InterruptedException, TimeoutException {
// Simulate a tap and make sure Content is not visible.
@@ -2337,10 +2334,9 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests swiping panel up and down after a long press search will only load the Content once.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
- @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+ @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
public void testLongPressMultipleSwipeOnlyLoadsContentOnce()
throws InterruptedException, TimeoutException {
// Simulate a long press and make sure no Content is created.
@@ -2412,10 +2408,9 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests that chained searches load correctly.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
- @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
+ @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
public void testChainedSearchLoadsCorrectSearchTerm()
throws InterruptedException, TimeoutException {
// Simulate a tap and make sure Content is not visible.
@@ -2458,7 +2453,6 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests that chained searches make Content visible when opening the Panel.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
@Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@@ -2513,7 +2507,6 @@ public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<Chro
/**
* Tests that a tap followed by opening the Panel does not remove the loaded URL from history.
*/
- @DisabledTest // https://crbug.com/551711
@SmallTest
@Feature({"ContextualSearch"})
@Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_NON_LOW_END_DEVICE})
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698