Complete support for Windows TLS destructors

Complete support for Windows TLS destructors

- Maintain a list of TLS destructors that should be run when a thread exits.
- Walk that list on thread exit and invoke destructors.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/e36b9fa3bf30ebbd5a527025393760667c0f05f4

[Cutch, 2015-10-15 18:06:35]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-10-15 22:42:48]

lgtm

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/growable_array.h
File runtime/vm/growable_array.h (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/growable_array.h...
runtime/vm/growable_array.h:117: if (i < length_ - 1) {
if (i < (length_ -1)) {

for better readability.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc
File runtime/vm/os_thread_win.cc (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc...
runtime/vm/os_thread_win.cc:493: }
Should this be
ASSERT(thread_locals_ != NULL);

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc...
runtime/vm/os_thread_win.cc:515: }
Ditto comment.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h
File runtime/vm/os_thread_win.h (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:141: ThreadDestructor destructor_;
DISALLOW_COPY_AND_ASSIGN(...);
DISALLOW_ALLOCATION(...);

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:149: class ThreadLocalData {
class ThreadLocalData : public AllStatic {

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:152: static void RemoveThreadLocal(ThreadLocalKey
key);
Should we make OSThread a friend class and make all of these also private
methods.

[Cutch, 2015-10-16 16:53:26]

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/growable_array.h
File runtime/vm/growable_array.h (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/growable_array.h...
runtime/vm/growable_array.h:117: if (i < length_ - 1) {
On 2015/10/15 22:42:48, siva wrote:
> if (i < (length_ -1)) {
> 
> for better readability.

Done.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc
File runtime/vm/os_thread_win.cc (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc...
runtime/vm/os_thread_win.cc:493: }
On 2015/10/15 22:42:48, siva wrote:
> Should this be
> ASSERT(thread_locals_ != NULL);

Done.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.cc...
runtime/vm/os_thread_win.cc:515: }
On 2015/10/15 22:42:48, siva wrote:
> Ditto comment.

Done.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h
File runtime/vm/os_thread_win.h (right):

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:141: ThreadDestructor destructor_;
On 2015/10/15 22:42:48, siva wrote:
> DISALLOW_COPY_AND_ASSIGN(...);
> DISALLOW_ALLOCATION(...);

Added DISALLOW_ALLOCATION but not DISALLOW_COPY_AND_ASSIGN because
MallocGrowableArray needs copy and assignment operators.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:149: class ThreadLocalData {
On 2015/10/15 22:42:48, siva wrote:
> class ThreadLocalData : public AllStatic {

Done.

https://codereview.chromium.org/1410493002/diff/1/runtime/vm/os_thread_win.h#...
runtime/vm/os_thread_win.h:152: static void RemoveThreadLocal(ThreadLocalKey
key);
On 2015/10/15 22:42:48, siva wrote:
> Should we make OSThread a friend class and make all of these also private
> methods.

Done.

[Cutch, 2015-10-16 17:00:49]

Committed patchset #3 (id:40001) manually as
e36b9fa3bf30ebbd5a527025393760667c0f05f4 (presubmit successful).